Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sql): Fix migrations for users who do not run MySQL #3721

Merged
merged 1 commit into from
Jun 4, 2020

Conversation

robzienert
Copy link
Member

Fixes spinnaker/spinnaker#5788

I had to change 20200424-index-deleted-executions-table.yml which I thought would break MySQL users due to checksum issues, but running locally I didn't encounter any problems. Maybe it's fine?

Anyway, this change will get non-MySQL users a working Orca, and MySQL users will be unaffected:

2020-06-03 15:37:11.999  INFO 99068 --- [           main] liquibase.changelog.ChangeSet            : [] Marking ChangeSet: classpath:db/changelog/20200603-deleted-executions-table-not-mysql.yml::create-deleted-executions-table-for-not-mysql::robzienert ran despite precondition failure due to onFail='MARK_RAN': 
          classpath:db/changelog-master.yml : Not precondition failed

2020-06-03 15:37:12.000  INFO 99068 --- [           main] liquibase.executor.jvm.JdbcExecutor      : [] SELECT MAX(ORDEREXECUTED) FROM orca.DATABASECHANGELOG
2020-06-03 15:37:12.002  INFO 99068 --- [           main] liquibase.executor.jvm.JdbcExecutor      : [] INSERT INTO orca.DATABASECHANGELOG (ID, AUTHOR, FILENAME, DATEEXECUTED, ORDEREXECUTED, MD5SUM, `DESCRIPTION`, COMMENTS, EXECTYPE, CONTEXTS, LABELS, LIQUIBASE, DEPLOYMENT_ID) VALUES ('create-deleted-executions-table-for-not-mysql', 'robzienert', 'classpath:db/changelog/20200603-deleted-executions-table-not-mysql.yml', NOW(), 39, '8:b333e8c8b075804f1c71fc60cd9d916b', 'createTable tableName=deleted_executions', '', 'MARK_RAN', NULL, NULL, '3.8.7', '1223831944')
2020-06-03 15:37:12.080  INFO 99068 --- [           main] liquibase.changelog.ChangeSet            : [] Marking ChangeSet: classpath:db/changelog/20200603-deleted-executions-table-not-mysql.yml::create-deleted-executions-index-for-not-mysql::robzienert ran despite precondition failure due to onFail='MARK_RAN': 
          classpath:db/changelog-master.yml : Not precondition failed

2020-06-03 15:37:12.081  INFO 99068 --- [           main] liquibase.executor.jvm.JdbcExecutor      : [] INSERT INTO orca.DATABASECHANGELOG (ID, AUTHOR, FILENAME, DATEEXECUTED, ORDEREXECUTED, MD5SUM, `DESCRIPTION`, COMMENTS, EXECTYPE, CONTEXTS, LABELS, LIQUIBASE, DEPLOYMENT_ID) VALUES ('create-deleted-executions-index-for-not-mysql', 'robzienert', 'classpath:db/changelog/20200603-deleted-executions-table-not-mysql.yml', NOW(), 40, '8:6df5b6d9c3df28ec52de2d40a8dfb491', 'createIndex indexName=deleted_at_idx, tableName=deleted_executions', '', 'MARK_RAN', NULL, NULL, '3.8.7', '1223831944')

@aleon1220
Copy link

Thanks for that one!

Copy link

@aleon1220 aleon1220 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great. Thanks!

Copy link
Contributor

@marchello2000 marchello2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you, sorry about messing this up

@marchello2000 marchello2000 added the ready to merge Approved and ready for merge label Jun 4, 2020
@mergify mergify bot merged commit 7465896 into spinnaker:master Jun 4, 2020
@mergify mergify bot added the auto merged Merged automatically by a bot label Jun 4, 2020
KathrynLewis pushed a commit to KathrynLewis/orca that referenced this pull request Jan 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto merged Merged automatically by a bot ready to merge Approved and ready for merge target-release/1.21
Projects
None yet
Development

Successfully merging this pull request may close these issues.

table deleted_executions does not get created. Orca working with SQL persistence in mariadb
4 participants