Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(manifests): revert manifest feat flag for disabling failing evaluations #3821

Merged
merged 2 commits into from
Jul 14, 2020
Merged

Conversation

zachsmith1
Copy link
Contributor

This reverts commit 786a365.

@spinnakerbot
Copy link
Contributor

The following commits need their title changed:

Please format your commit title into the form:

<type>(<scope>): <subject>, e.g. fix(kubernetes): address NPE in status check

This allows us to easily generate changelogs & determine semantic version numbers when cutting releases. You can read more about commit conventions here.

Copy link
Member

@kevinawoo kevinawoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

discussed in k8s sig to remove it in favor of change the PCF UI to support this, 👍

@kevinawoo kevinawoo self-assigned this Jul 14, 2020
@kevinawoo kevinawoo merged commit 465539d into spinnaker:master Jul 14, 2020
KathrynLewis pushed a commit to KathrynLewis/orca that referenced this pull request Jan 31, 2021
…ations (spinnaker#3821)

Co-authored-by: Zach Smith <zachsmith@Zachs-MBP-2.attlocal.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants