fix(stageExecution): In evaluable variable stage restart scenario variables are not cleaned properly (#16) #4307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iables are not cleaned properly (#16)
dogonthehorizon
approved these changes
Oct 12, 2022
|
@Mergifyio backport release-1.27.x release-1.28.x release-1.29.x |
✅ Backports have been created
|
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: Expression evaluates the previous data when upstream stage(Manual Judgement) is restarted (or other restar case).
Steps to reproduce:
Execute the pipeline and choose Continue at the Manual Judgement stage. Upon completion note that the status variable inside "Evaluate Variables" was evaluated to 'success'; this is correct.
Execute the pipeline again and when it reaches the Manual Judgment, wait 1 min for it to timeout or stop manually the judgment. Upon timeout, note that the status variable inside "Evaluate Variables" was evaluated to 'failed'; again this is correct.
Click on the failed Manual Judgment stage and choose Actions -> Restart Manual Judgement from the drop down.
The pipeline will execute. Choose Continue for the Manual Judgement. Upon completion note that the status variable inside "Evaluate Variables" has still evaluated to 'failed'; this is incorrect as the deploy stage was successful.
Solution:
EvaluateVariablesStage does not have logic created for restart scenarios, so the values for the expression previously executed are preserved.
prepareStageForRestart function for EvaluateVariablesStage object needs clear the values for a new execution.
Scenario whit approach applied: