Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(front50): teach MonitorPipelineTask to handle missing/null execution ids (backport #4555) #4556

Merged
merged 1 commit into from
Oct 9, 2023
Merged

fix(front50): teach MonitorPipelineTask to handle missing/null execution ids (backport #4555) #4556

merged 1 commit into from
Oct 9, 2023

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Oct 9, 2023

This is an automatic backport of pull request #4555 done by Mergify.

Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

@dbyron-sf @mergify
fix(front50): teach MonitorPipelineTask to handle missing/null execut…
c6ea98e 
…ion ids (#4555)

give the task terminal status in this case since that feels closer to the truth than
succeeded even though the error is likely elsewhere (e.g. in a StartPipelineTask).

(cherry picked from commit 7523f5d)
@mergify mergify bot mentioned this pull request Oct 9, 2023
Merged
@dbyron-sf dbyron-sf added the ready to merge Approved and ready for merge label Oct 9, 2023
@mergify mergify bot added the auto merged Merged automatically by a bot label Oct 9, 2023
@mergify mergify bot merged commit a65d34f into release-1.28.x Oct 9, 2023
4 checks passed
@mergify mergify bot deleted the mergify/bp/release-1.28.x/pr-4555 branch October 9, 2023 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbyron-sf dbyron-sf dbyron-sf approved these changes

Assignees
No one assigned
Labels
auto merged Merged automatically by a bot ready to merge Approved and ready for merge target-release/1.28
Projects
None yet
Milestone
No milestone
2 participants
@dbyron-sf @spinnakerbot