Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(jenkins): Enable properties and artifacts with job name as query parameter #4661

Merged
merged 3 commits into from
Feb 27, 2024

Conversation

christosarvanitis
Copy link
Contributor

@christosarvanitis christosarvanitis commented Feb 26, 2024

Fixes spinnaker/spinnaker#6928

The implementation of:

        feature:
          igor:
            jobNameAsQueryParameter: true

did not include the support for Jenkins artifacts and property files leading to failures on Manual triggers and rerun's of a Spinnaker pipeline retrieving BuildInfo from the sub-folder Jenkins job.

@christosarvanitis christosarvanitis marked this pull request as ready for review February 26, 2024 13:34
@jasonmcintosh jasonmcintosh added the ready to merge Approved and ready for merge label Feb 27, 2024
@mergify mergify bot added the auto merged Merged automatically by a bot label Feb 27, 2024
@mergify mergify bot merged commit fa91381 into spinnaker:master Feb 27, 2024
4 checks passed
@ovidiupopa07
Copy link
Contributor

@Mergifyio backport release-1.33.x release-1.32.x

Copy link
Contributor

mergify bot commented Feb 27, 2024

backport release-1.33.x release-1.32.x

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Feb 27, 2024
…parameter (#4661)

* fix(jenkins): Enable properties and artifacts with job name as query parameter

* fix(jenkins): Enable properties and artifacts with job name as query parameter

---------

Co-authored-by: Jason <mcintoshj@gmail.com>
(cherry picked from commit fa91381)
mergify bot pushed a commit that referenced this pull request Feb 27, 2024
…parameter (#4661)

* fix(jenkins): Enable properties and artifacts with job name as query parameter

* fix(jenkins): Enable properties and artifacts with job name as query parameter

---------

Co-authored-by: Jason <mcintoshj@gmail.com>
(cherry picked from commit fa91381)
mergify bot added a commit that referenced this pull request Feb 27, 2024
…parameter (#4661) (#4664)

* fix(jenkins): Enable properties and artifacts with job name as query parameter

* fix(jenkins): Enable properties and artifacts with job name as query parameter

---------

Co-authored-by: Jason <mcintoshj@gmail.com>
(cherry picked from commit fa91381)

Co-authored-by: Christos Arvanitis <christos.arvanitis@armory.io>
mergify bot added a commit that referenced this pull request Feb 27, 2024
…parameter (#4661) (#4663)

* fix(jenkins): Enable properties and artifacts with job name as query parameter

* fix(jenkins): Enable properties and artifacts with job name as query parameter

---------

Co-authored-by: Jason <mcintoshj@gmail.com>
(cherry picked from commit fa91381)

Co-authored-by: Christos Arvanitis <christos.arvanitis@armory.io>
@jasonmcintosh
Copy link
Member

https://github.com/Mergifyio backport release-1.31.x

Copy link
Contributor

mergify bot commented Mar 14, 2024

backport release-1.31.x

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Mar 14, 2024
…parameter (#4661)

* fix(jenkins): Enable properties and artifacts with job name as query parameter

* fix(jenkins): Enable properties and artifacts with job name as query parameter

---------

Co-authored-by: Jason <mcintoshj@gmail.com>
(cherry picked from commit fa91381)
mergify bot added a commit that referenced this pull request Mar 14, 2024
…parameter (#4661) (#4677)

* fix(jenkins): Enable properties and artifacts with job name as query parameter

* fix(jenkins): Enable properties and artifacts with job name as query parameter

---------

Co-authored-by: Jason <mcintoshj@gmail.com>
(cherry picked from commit fa91381)

Co-authored-by: Christos Arvanitis <christos.arvanitis@armory.io>
Co-authored-by: Jason <mcintoshj@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto merged Merged automatically by a bot ready to merge Approved and ready for merge target-release/1.34
Projects
None yet
4 participants