fix(queue): Fix SqlQueue#doContainsMessage to handle queues with more than 100 items (backport #4648)
#4683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
…more than 100 items (#4648) `SqlQueue#doContainsMessage` doesn't process more than 1 batch because of an incorrect loop inside. When the last element in the batch is processed (`ResultSet#next` returns `false`), the following invocation of `ResultSet#getRow` will return 0. No matter how many rows were processed before. Basically, this PR is just a copy of #4184 with addressed comments. But #4184 is abandoned so opened this one. Kudos to Ivor for the original PR Co-authored-by: Jason <mcintoshj@gmail.com> (cherry picked from commit 0a52909)
jasonmcintosh
approved these changes
Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SqlQueue#doContainsMessagedoesn't process more than 1 batch because of an incorrect loop inside. When the last element in the batch is processed (ResultSet#nextreturnsfalse), the following invocation ofResultSet#getRowwill return 0. No matter how many rows were processed before.Basically, this PR is just a copy of #4184 with addressed comments. But #4184 is abandoned so opened this one. Kudos to Ivor for the original PR
This is an automatic backport of pull request #4648 done by [Mergify](https://mergify.com).