Skip to content

Commit

Permalink
fix(bakeManifest): helm --set option (#441)
Browse files Browse the repository at this point in the history
adds an option to toggle between `--set` and `--set-string`. we recently
had to revert a commit which changed `--set-string` to `--set` and
introduced a breaking change. this keeps the default behavior of
`--set-string` but allows users to choose which option they want to use.
  • Loading branch information
ethanfrogers committed Oct 11, 2019
1 parent 746fa9c commit abe19bb
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -11,4 +11,5 @@
public class HelmBakeManifestRequest extends BakeManifestRequest {
String namespace;
List<Artifact> inputArtifacts;
boolean rawOverrides;
}
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,8 @@ public BakeRecipe buildBakeRecipe(BakeManifestEnvironment env, HelmBakeManifestR
for (Map.Entry<String, Object> entry : overrides.entrySet()) {
overrideList.add(entry.getKey() + "=" + entry.getValue().toString());
}
command.add("--set-string");
String overrideOption = request.isRawOverrides() ? "--set" : "--set-string";
command.add(overrideOption);
command.add(overrideList.stream().collect(Collectors.joining(",")));
}

Expand Down

0 comments on commit abe19bb

Please sign in to comment.