Skip to content

Commit

Permalink
fix(bake/helm): use --set instead of --set-string (#418)
Browse files Browse the repository at this point in the history
using `--set` instead of `--set-string` ensures that values of different types get injected into into the chart properly. the most common use case for this is values that are used as `bool` in templates. Previously, these values would cause errors because they weren't properly converted.
  • Loading branch information
ethanfrogers committed Aug 21, 2019
1 parent 6664a44 commit c652935
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ public BakeRecipe buildBakeRecipe(BakeManifestEnvironment env, HelmBakeManifestR
for (Map.Entry<String, Object> entry : overrides.entrySet()) {
overrideList.add(entry.getKey() + "=" + entry.getValue().toString());
}
command.add("--set-string");
command.add("--set");
command.add(overrideList.stream().collect(Collectors.joining(",")));
}

Expand Down

0 comments on commit c652935

Please sign in to comment.