feat(install): Install packer when rosco is installed. #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm going to add a check if |
lwander
reviewed
Mar 2, 2017
rosco-web/pkg_scripts/postInstall.sh
Outdated
| @@ -11,4 +11,13 @@ if [ -z `getent passwd spinnaker` ]; then | |||
| useradd --gid spinnaker spinnaker -m --home-dir /home/spinnaker | |||
| fi | |||
|
|
|||
| # install packer | |||
| pushd | |||
| mkdir /packer && \ | |||
There was a problem hiding this comment.
I don't think /packer is the right way to do this. I'd create a tempdir and install there, removing the tempdir after.
There was a problem hiding this comment.
The Dockerfile installs to /packer and then appends this to ENV.
There was a problem hiding this comment.
Dockerfiles are a bit of a special case, since it's more OK to pollute the / directory in a containerized environment. This should end up in /usr/bin.
rosco-web/pkg_scripts/postInstall.sh
Outdated
| pushd | ||
| mkdir /packer && \ | ||
| cd /packer \ | ||
| wget https://releases.hashicorp.com/packer/0.12.1/packer_0.12.1_linux_amd64.zip && \ |
There was a problem hiding this comment.
Pull this version into a top-level env var so it's easy to update.
|
Updated & tested. |
opsmxdemo
pushed a commit
to OpsMx/rosco
that referenced
this pull request
Sep 15, 2020
opsmxdemo
pushed a commit
to OpsMx/rosco
that referenced
this pull request
Sep 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.