Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(packer): ability to add default packer options via spring config #372

Merged
merged 2 commits into from
May 16, 2019

Conversation

asher
Copy link
Contributor

@asher asher commented May 15, 2019

No description provided.

@asher asher requested a review from jeyrschabu May 15, 2019 22:11
@asher asher merged commit 0ababe1 into spinnaker:master May 16, 2019
@matthack
Copy link
Contributor

@asher I'm noticing that the options I'm passing to packer to use a specific template file and environment variables via the bake stage are getting ignored now. Not sure if this is a problem unique to me.

image

Log entry where it doesn't used the cws-ebs.json template I specified.

2019-05-20 20:25:11.772 INFO 1394 --- [tionScheduler-1] c.n.s.rosco.jobs.local.JobExecutorLocal : Executing cbb521d6-725c-4b25-8be9-4a8858e91076 with tokenized command: [packer, build, -color=false, -var, aws_region=us-west-2, -var, aws_instance_type=t2.micro, -var, aws_source_ami=ami-b9ff39d9, -var, aws_target_ami=apache2-all-20190520202508-xenial, -var, aws_ssh_username=ubuntu, -var, package_type=deb, -var, packages=apache2, -var, configDir=/opt/rosco/config/packer, /opt/rosco/config/packer/aws-ebs.json] (executionId: 01DBBEPN7BA0M42PT4FXTCHBJA:01DBBEPNFG5WEHER1NNJ0B3MNW:1:25c13fa1-d5c9-4b04-95d1-f4485c8418c5)

Bakery log ignoring the subnet:

==> amazon-ebs: Prevalidating AMI Name: apache2-all-20190520202508-xenial
amazon-ebs: Found Image ID: ami-b9ff39d9
==> amazon-ebs: Describing the subnet: subnet-1ef6087a returned error: InvalidSubnetID.NotFound: The subnet ID 'subnet-1ef6087a' does not exist
==> amazon-ebs: status code: 400, request id: 2f9d2a4d-4db8-4cca-b179-940439c70b97.
Build 'amazon-ebs' errored: Describing the subnet: subnet-1ef6087a returned error: InvalidSubnetID.NotFound: The subnet ID 'subnet-1ef6087a' does not exist
status code: 400, request id: 2f9d2a4d-4db8-4cca-b179-940439c70b97.

==> Some builds didn't complete successfully and had errors:
--> amazon-ebs: Describing the subnet: subnet-1ef6087a returned error: InvalidSubnetID.NotFound: The subnet ID 'subnet-1ef6087a' does not exist
status code: 400, request id: 2f9d2a4d-4db8-4cca-b179-940439c70b97.

==> Builds finished but no artifacts were created.

@asher
Copy link
Contributor Author

asher commented May 20, 2019

@matthack This is due to a serialization regression in Orca. A fix was committed earlier today here: spinnaker/orca#2927

@matthack
Copy link
Contributor

Good to know. Rosco/orca are working as expected after upgrading orca. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants