fix(artifacts): Fix NPE on empty artifact #373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If an artifact is empty, we throw an NPE when downloading it rather than just pass an empty artifact along to the caller. In general it's not overly useful to have an empty artifact, but in some cases (ex: a values.yaml file for a Helm bake) it's reasonable to have no content.
|
@spinnakerbot cherry-pick 1.14 |
spinnakerbot
pushed a commit
that referenced
this pull request
May 17, 2019
If an artifact is empty, we throw an NPE when downloading it rather than just pass an empty artifact along to the caller. In general it's not overly useful to have an empty artifact, but in some cases (ex: a values.yaml file for a Helm bake) it's reasonable to have no content.
|
Cherry pick successful: #374 |
ezimanyi
pushed a commit
that referenced
this pull request
May 17, 2019
If an artifact is empty, we throw an NPE when downloading it rather than just pass an empty artifact along to the caller. In general it's not overly useful to have an empty artifact, but in some cases (ex: a values.yaml file for a Helm bake) it's reasonable to have no content.
opsmxdemo
pushed a commit
to OpsMx/rosco
that referenced
this pull request
Sep 15, 2020
If an artifact is empty, we throw an NPE when downloading it rather than just pass an empty artifact along to the caller. In general it's not overly useful to have an empty artifact, but in some cases (ex: a values.yaml file for a Helm bake) it's reasonable to have no content.
opsmxdemo
pushed a commit
to OpsMx/rosco
that referenced
this pull request
Sep 16, 2020
If an artifact is empty, we throw an NPE when downloading it rather than just pass an empty artifact along to the caller. In general it's not overly useful to have an empty artifact, but in some cases (ex: a values.yaml file for a Helm bake) it's reasonable to have no content.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes spinnaker/spinnaker#4387
If an artifact is empty, we throw an NPE when downloading it rather than just pass an empty artifact along to the caller.
In general it's not overly useful to have an empty artifact, but in some cases (ex: a values.yaml file for a Helm bake) it's reasonable to have no content.