refactor(core): Use a rest controller for status endpoints #388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The status endpoint tests are currently testing AllStatusEndpoint and InstanceStatusEndpoint which are pass-through classes that will be removed; update the tests to directly test StatusHandler.
The Endpoint classes that are used to implement the status endpoint have significantly changed in Spring Boot 2. Instead of creating and exposing an endpoint, just use a rest controller.
The prior commit moved everything out of the endpoints package into other packages, so we should remove it from the component scan.
opsmxdemo
pushed a commit
to OpsMx/rosco
that referenced
this pull request
Sep 15, 2020
…#388) * test(core): Update tests to test statusHandler The status endpoint tests are currently testing AllStatusEndpoint and InstanceStatusEndpoint which are pass-through classes that will be removed; update the tests to directly test StatusHandler. * refactor(core): Use a rest controller for status endpoints The Endpoint classes that are used to implement the status endpoint have significantly changed in Spring Boot 2. Instead of creating and exposing an endpoint, just use a rest controller. * fix(core): Remove package from componentscan The prior commit moved everything out of the endpoints package into other packages, so we should remove it from the component scan.
opsmxdemo
pushed a commit
to OpsMx/rosco
that referenced
this pull request
Sep 16, 2020
…#388) * test(core): Update tests to test statusHandler The status endpoint tests are currently testing AllStatusEndpoint and InstanceStatusEndpoint which are pass-through classes that will be removed; update the tests to directly test StatusHandler. * refactor(core): Use a rest controller for status endpoints The Endpoint classes that are used to implement the status endpoint have significantly changed in Spring Boot 2. Instead of creating and exposing an endpoint, just use a rest controller. * fix(core): Remove package from componentscan The prior commit moved everything out of the endpoints package into other packages, so we should remove it from the component scan.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test(core): Update tests to test statusHandler
The status endpoint tests are currently testing AllStatusEndpoint and InstanceStatusEndpoint which are pass-through classes that will be removed; update the tests to directly test StatusHandler.
refactor(core): Use a rest controller for status endpoints
The Endpoint classes that are used to implement the status endpoint have significantly changed in Spring Boot 2. Instead of creating and exposing an endpoint, just use a rest controller.