test(core): Fix tests that break with groovy upgrade #390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A few of the rosco tests fail when we upgrade groovy because groovy no longer considers objects equal they are identical except that a field is null in one vs empty array in the other. That was masking the fact that we weren't stubbing out the getMaskedPackerParameters function on our mock CloudProviderBakeHandler. Add in that stubbing, and also change the calling code to use the actual accessor rather than the groovy-generated synthetic one. There's probably a way to factor out some of the common logic in the tests so changes like this don't need to touch as many lines, but for now just making the required change in each test.
opsmxdemo
pushed a commit
to OpsMx/rosco
that referenced
this pull request
Sep 15, 2020
A few of the rosco tests fail when we upgrade groovy because groovy no longer considers objects equal they are identical except that a field is null in one vs empty array in the other. That was masking the fact that we weren't stubbing out the getMaskedPackerParameters function on our mock CloudProviderBakeHandler. Add in that stubbing, and also change the calling code to use the actual accessor rather than the groovy-generated synthetic one. There's probably a way to factor out some of the common logic in the tests so changes like this don't need to touch as many lines, but for now just making the required change in each test.
opsmxdemo
pushed a commit
to OpsMx/rosco
that referenced
this pull request
Sep 16, 2020
A few of the rosco tests fail when we upgrade groovy because groovy no longer considers objects equal they are identical except that a field is null in one vs empty array in the other. That was masking the fact that we weren't stubbing out the getMaskedPackerParameters function on our mock CloudProviderBakeHandler. Add in that stubbing, and also change the calling code to use the actual accessor rather than the groovy-generated synthetic one. There's probably a way to factor out some of the common logic in the tests so changes like this don't need to touch as many lines, but for now just making the required change in each test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few of the rosco tests fail when we upgrade groovy because groovy no longer considers objects equal they are identical except that a field is null in one vs empty array in the other.
That was masking the fact that we weren't stubbing out the getMaskedPackerParameters function on our mock CloudProviderBakeHandler. Add in that stubbing, and also change the calling code to use the actual accessor rather than the groovy-generated synthetic one.
There's probably a way to factor out some of the common logic in the tests so changes like this don't need to touch as many lines, but for now just making the required change in each test.