fix(helm): Fix baking of helm artifacts #442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We currently throw an exception if a helm artifact doesn't have a reference. We're only using that reference to generate a file name to use when downloading the artifact; helm artifacts don't actually need a reference. Fix this by just falling back to the name-version if there is no reference defined.
|
@spinnakerbot 🍒 ⛏️ 1.16 |
|
Cherry pick failed: Command failed (cherry pick commit 746fa9c) with exit code 1: |
|
Manual 🍒 ⛏️ to 1.16 in #443 . |
louisjimenez
pushed a commit
that referenced
this pull request
Oct 10, 2019
We currently throw an exception if a helm artifact doesn't have a reference. We're only using that reference to generate a file name to use when downloading the artifact; helm artifacts don't actually need a reference. Fix this by just falling back to the name-version if there is no reference defined.
opsmxdemo
pushed a commit
to OpsMx/rosco
that referenced
this pull request
Sep 15, 2020
We currently throw an exception if a helm artifact doesn't have a reference. We're only using that reference to generate a file name to use when downloading the artifact; helm artifacts don't actually need a reference. Fix this by just falling back to the name-version if there is no reference defined.
opsmxdemo
pushed a commit
to OpsMx/rosco
that referenced
this pull request
Sep 16, 2020
We currently throw an exception if a helm artifact doesn't have a reference. We're only using that reference to generate a file name to use when downloading the artifact; helm artifacts don't actually need a reference. Fix this by just falling back to the name-version if there is no reference defined.
sitay93
pushed a commit
to spotinst/spinnaker-rosco
that referenced
this pull request
Jun 27, 2023
We currently throw an exception if a helm artifact doesn't have a reference. We're only using that reference to generate a file name to use when downloading the artifact; helm artifacts don't actually need a reference. Fix this by just falling back to the name-version if there is no reference defined.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes spinnaker/spinnaker#4874.
We currently throw an exception if a helm artifact doesn't have a reference. We're only using that reference to generate a file name to use when downloading the artifact; helm artifacts don't actually need a reference.
Fix this by just falling back to the name-version if there is no reference defined.
(I'd like to refactor this code a bit, and just use a UUID as the file name to avoid all this, but this felt like a smaller change and I'd like to cherry pick the fix.)