Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(build): Install Helm3 Binary to Rosco Container Image #536

Merged
merged 1 commit into from
Feb 20, 2020

Conversation

evansb
Copy link
Contributor

@evansb evansb commented Feb 20, 2020

Install Helm 3 Binary alongside Helm 2.

Part of spinnaker/spinnaker#5474

Test Plan

$ docker build -t compile -f Dockerfile.compile .
$ docker build -t slim -f Dockerfile.slim .
$ docker run --rm slim helm version
Client: &version.Version{SemVer:"v2.16.3", GitCommit:"1ee0254c86d4ed6887327dabed7aa7da29d7eb0d", GitTreeState:"clean"}
Error: Get http://localhost:8080/api/v1/namespaces/kube-system/pods?labelSelector=app%3Dhelm%2Cname%3Dtiller: dial tcp 127.0.0.1:8080: connect: connection refused
$ docker run --rm slim helm3 version
version.BuildInfo{Version:"v3.1.0", GitCommit:"b29d20baf09943e134c2fa5e1e1cab3bf93315fa", GitTreeState:"clean", GoVersion:"go1.13.7"}

@evansb evansb changed the title feat(docker): Install Helm3 Binary to Rosco Container Image chore(build): Install Helm3 Binary to Rosco Container Image Feb 20, 2020
Copy link
Contributor

@ethanfrogers ethanfrogers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ethanfrogers ethanfrogers added the ready to merge Approved and ready for merge label Feb 20, 2020
@mergify mergify bot merged commit 5da1ba0 into spinnaker:master Feb 20, 2020
@mergify mergify bot added the auto merged label Feb 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants