Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(rosco): Add support for Redis SSL #719

Merged
merged 2 commits into from
Dec 7, 2020
Merged

feat(rosco): Add support for Redis SSL #719

merged 2 commits into from
Dec 7, 2020

Conversation

tompiscitell
Copy link
Contributor

Related to spinnaker/spinnaker#5470. Initializes JedisPool to use SSL if the Redis connection URL uses rediss for its scheme.

@karlskewes
Copy link
Contributor

LGTM, thanks for doing this.

KathrynLewis
KathrynLewis approved these changes Dec 7, 2020
View reviewed changes
Copy link
Contributor

@KathrynLewis KathrynLewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dogonthehorizon dogonthehorizon added the ready to merge Approved and ready for merge label Dec 7, 2020
@mergify mergify bot merged commit 8662444 into spinnaker:master Dec 7, 2020
@mergify mergify bot added the auto merged label Dec 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ezimanyi ezimanyi ezimanyi approved these changes

@dogonthehorizon dogonthehorizon dogonthehorizon approved these changes

@KathrynLewis KathrynLewis KathrynLewis approved these changes

Assignees
No one assigned
Labels
auto merged ready to merge Approved and ready for merge target-release/1.24
Projects
None yet
Milestone
No milestone
6 participants
@tompiscitell @karlskewes @ezimanyi @dogonthehorizon @KathrynLewis @spinnakerbot