Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(logs): allow anonymous clouddriver artifact fetching #748

Merged

Conversation

dbyron0
Copy link
Contributor

@dbyron0 dbyron0 commented Dec 4, 2020

to clean up warnings like

---> HTTP PUT http://spin-clouddriver-ro.spinnaker-stage:7002/artifacts/fetch/
2020-11-20 22:03:03.649  WARN 1 --- [0.0-8087-exec-1] c.n.s.okhttp.OkHttp3MetricsInterceptor   : Request PUT:http://spin-clouddriver-ro.spinnaker:7002/artifacts/fetch/ is missing [X-SPINNAKER-USER, X-SPINNAKER-ACCOUNTS] authentication headers and will be treated as anonymous.
Request from: com.netflix.spinnaker.okhttp.MetricsInterceptor.doIntercept(MetricsInterceptor.java:98)
	at com.netflix.spinnaker.okhttp.OkHttp3MetricsInterceptor.intercept(OkHttp3MetricsInterceptor.java:36)
	at com.netflix.spinnaker.rosco.manifests.ArtifactDownloaderImpl.lambda$downloadArtifact$0(ArtifactDownloaderImpl.java:29)
	at com.netflix.spinnaker.kork.core.RetrySupport.retry(RetrySupport.java:34)
	at com.netflix.spinnaker.kork.core.RetrySupport.retry(RetrySupport.java:27)
	at com.netflix.spinnaker.rosco.manifests.ArtifactDownloaderImpl.downloadArtifact(ArtifactDownloaderImpl.java:29)
	at com.netflix.spinnaker.rosco.manifests.BakeManifestEnvironment.downloadArtifactTarballAndExtract(BakeManifestEnvironment.java:74)
	at com.netflix.spinnaker.rosco.manifests.helm.HelmTemplateUtils.buildBakeRecipe(HelmTemplateUtils.java:52)
	at com.netflix.spinnaker.rosco.manifests.helm.HelmBakeManifestService.bake(HelmBakeManifestService.java:38)
	at com.netflix.spinnaker.rosco.manifests.helm.HelmBakeManifestService.bake(HelmBakeManifestService.java:15)
	at com.netflix.spinnaker.rosco.controllers.V2BakeryController.doBake(V2BakeryController.java:44)
	at com.netflix.spinnaker.rosco.filters.SimpleCORSFilter.doFilter(SimpleCORSFilter.groovy:34)
	at com.netflix.spinnaker.filters.AuthenticatedRequestFilter.doFilter(AuthenticatedRequestFilter.groovy:147)

to clean up warnings like

---> HTTP PUT http://spin-clouddriver-ro.spinnaker-stage:7002/artifacts/fetch/
2020-11-20 22:03:03.649  WARN 1 --- [0.0-8087-exec-1] c.n.s.okhttp.OkHttp3MetricsInterceptor   : Request PUT:http://spin-clouddriver-ro.spinnaker:7002/artifacts/fetch/ is missing [X-SPINNAKER-USER, X-SPINNAKER-ACCOUNTS] authentication headers and will be treated as anonymous.
Request from: com.netflix.spinnaker.okhttp.MetricsInterceptor.doIntercept(MetricsInterceptor.java:98)
	at com.netflix.spinnaker.okhttp.OkHttp3MetricsInterceptor.intercept(OkHttp3MetricsInterceptor.java:36)
	at com.netflix.spinnaker.rosco.manifests.ArtifactDownloaderImpl.lambda$downloadArtifact$0(ArtifactDownloaderImpl.java:29)
	at com.netflix.spinnaker.kork.core.RetrySupport.retry(RetrySupport.java:34)
	at com.netflix.spinnaker.kork.core.RetrySupport.retry(RetrySupport.java:27)
	at com.netflix.spinnaker.rosco.manifests.ArtifactDownloaderImpl.downloadArtifact(ArtifactDownloaderImpl.java:29)
	at com.netflix.spinnaker.rosco.manifests.BakeManifestEnvironment.downloadArtifactTarballAndExtract(BakeManifestEnvironment.java:74)
	at com.netflix.spinnaker.rosco.manifests.helm.HelmTemplateUtils.buildBakeRecipe(HelmTemplateUtils.java:52)
	at com.netflix.spinnaker.rosco.manifests.helm.HelmBakeManifestService.bake(HelmBakeManifestService.java:38)
	at com.netflix.spinnaker.rosco.manifests.helm.HelmBakeManifestService.bake(HelmBakeManifestService.java:15)
	at com.netflix.spinnaker.rosco.controllers.V2BakeryController.doBake(V2BakeryController.java:44)
	at com.netflix.spinnaker.rosco.filters.SimpleCORSFilter.doFilter(SimpleCORSFilter.groovy:34)
	at com.netflix.spinnaker.filters.AuthenticatedRequestFilter.doFilter(AuthenticatedRequestFilter.groovy:147)
@spinnakerbot
Copy link
Contributor

Please delete the pull request instructions from the body of your pull request message.

The instructions start with the line:

We prefer small, well tested pull requests.

You can reopen your pull request when this has been addressed.

@ezimanyi ezimanyi reopened this Dec 4, 2020
@ezimanyi ezimanyi added the ready to merge Approved and ready for merge label Dec 4, 2020
@mergify mergify bot merged commit 5349ef9 into spinnaker:master Dec 4, 2020
@mergify mergify bot added the auto merged label Dec 4, 2020
@dbyron0 dbyron0 deleted the remove_warnings_when_fetching_artifacts branch December 4, 2020 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants