Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(tests): Introduce junit5 vintage engine for running junit4 test cases over junit5 in rosco #958

Merged
merged 1 commit into from
Mar 2, 2023
Merged

fix(tests): Introduce junit5 vintage engine for running junit4 test cases over junit5 in rosco #958

merged 1 commit into from
Mar 2, 2023

Commits on Mar 2, 2023

  1. fix(tests): Introduce junit5 vintage engine for running junit4 test c… 

    …ases over junit5 in rosco

Spring boot 2.4.x removed JUnit5 vintage engine from spring-boot-starter-test.
[https://github.com/spring-projects/spring-boot/wiki/Spring-Boot-2.4-Release-Notes#junit-5s-vintage-engine-removed-from-spring-boot-starter-test]
It is required for executing junit4 based test cases in rosco.
So, introducing junit-vintage-engine dependency in build.gradle, using testRuntimeOnly() as suggested in section 3.1 of https://junit.org/junit5/docs/5.6.2/user-guide/index.pdf

After applying this fix, coverage increased from 217 to 252 test case executions.
    @j-sandy
    j-sandy committed Mar 2, 2023
    Configuration menu
    Copy the full SHA
    05cc087 View commit details
    Browse the repository at this point in the history