improve prometheus operator setup script #211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following commits need their title changed:
Please format your commit title into the form:
This allows us to easily generate changelogs & determine semantic version numbers when cutting releases. You can read more about commit conventions here. |
n0npax
reviewed
Jul 1, 2019
spinnaker-monitoring-third-party/third_party/prometheus_operator/setup.sh
Show resolved
Hide resolved
louisjimenez
approved these changes
Jul 1, 2019
spinnaker-monitoring-third-party/third_party/prometheus_operator/README.md
Outdated
Show resolved
Hide resolved
|
@milesmatthias is this ready for merge? Happy to do so once comments are addressed or marked as resolved. |
|
@louisjimenez just pushed a commit resolving those comments. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's important to put the service monitor in the same namespace as Spinnaker, so have that be the optional parameter in the setup script.