fix(google): Handle domain names in project names. (#1509)

spinnaker · Mar 27, 2017 · e89f2a8 · e89f2a8
1 parent bc76ca1
commit e89f2a8
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/etc/default/spinnaker b/etc/default/spinnaker
@@ -29,7 +29,10 @@ function __get_google_metadata_value() {
 
 function __determine_default_bucket() {
   if [[ ! -z "${SPINNAKER_GOOGLE_PROJECT_ID}" ]]; then
-    echo "spinnaker-${SPINNAKER_GOOGLE_PROJECT_ID//google.com:/}"
+    # dot and colon are not valid bucket characters
+    # however they are valid project id names (e.g. google.com:)
+    # so replace those bad chars with '-'
+    echo "spinnaker-${SPINNAKER_GOOGLE_PROJECT_ID}" | tr ".:" "--"
   else
     echo ""
   fi