Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code duplication in Igor polling consumers #2166

Closed
wheleph opened this issue Dec 13, 2017 · 1 comment · Fixed by spinnaker/igor#209
Closed

Code duplication in Igor polling consumers #2166

wheleph opened this issue Dec 13, 2017 · 1 comment · Fixed by spinnaker/igor#209

Comments

@wheleph
Copy link

wheleph commented Dec 13, 2017

Igor has concept of polling monitors that detect changes in external systems (Travis, Jenkins etc). Those classes have similar structure and much code is copy/pasted among them.

This ticket is a prerequisite for #2047 since for that one a new polling monitor needs to be created and it will make situation even worse unless this issue is addressed first.
@wheleph wheleph mentioned this issue Dec 13, 2017
Merged
@wheleph
Copy link
Author

wheleph commented Dec 13, 2017

@jeyrschabu could you have a look at the PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor(core): Reduce code duplication in polling monitors bolcom/igor
1 participant
@wheleph