Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align spinnaker-client with recent Orca changes, and update Asgard #280

Closed
ajordens opened this issue Dec 13, 2014 · 4 comments
Closed

Align spinnaker-client with recent Orca changes, and update Asgard #280

ajordens opened this issue Dec 13, 2014 · 4 comments
Assignees

Comments

@ajordens
Copy link
Contributor

It would seem we have a few changes that have propagated out to Asgard via the spinnaker-client.

Two that I've noticed:

  • a new TaskStatus of STARTING (saw this Friday)
  • java.lang.ClassCastException: java.lang.String cannot be cast to java.lang.Integer at com.netflix.spinnaker.client.model.Task.single(Task.java:175) at com.netflix.spinnaker.client.model.Task.load(Task.java:156) at com.netflix.spinnaker.client.model.ops.AbstractTaskBackedApplicationOperation.submit(AbstractTaskBackedApplicationOperation.java:46) at com.netflix.spinnaker.client.model.ops.CreateApplicationOperation.submit(CreateApplicationOperation.java:16) at com.netflix.spinnaker.client.model.MutableApplication.save(MutableApplication.java:303) at com.netflix.spinnaker.client.model.MutableApplication.saveAndGet(MutableApplication.java:319) at com.netflix.asgard.applications.SpinnakerApplicationService$_createRegisteredApplication_closure5.doCall(SpinnakerApplicationService.groovy:157) at com.netflix.asgard.TaskService.doWork(TaskService.groovy:92) at com.netflix.asgard.TaskService.runTask(TaskService.groovy:81)

Asgard is super fragile, and I'm not sure I'm comfortable re-enabling before we get some chex work done to at least sanity check the relevant bits.

@ajordens ajordens self-assigned this Dec 13, 2014
@claymccoy
Copy link

Can you briefly explain the interactions that you would like to verify for
this?

On Sat, Dec 13, 2014 at 8:10 AM, Adam Jordens notifications@github.com
wrote:

It would seem we have a few changes that have propagated out to Asgard via
the spinnaker-client.

Two that I've noticed:

a new TaskStatus of STARTING (saw this Friday)

java.lang.ClassCastException: java.lang.String cannot be cast to
java.lang.Integer
at com.netflix.spinnaker.client.model.Task.single(Task.java:175)
at com.netflix.spinnaker.client.model.Task.load(Task.java:156)
at
com.netflix.spinnaker.client.model.ops.AbstractTaskBackedApplicationOperation.submit(AbstractTaskBackedApplicationOperation.java:46)
at
com.netflix.spinnaker.client.model.ops.CreateApplicationOperation.submit(CreateApplicationOperation.java:16)
at
com.netflix.spinnaker.client.model.MutableApplication.save(MutableApplication.java:303)
at
com.netflix.spinnaker.client.model.MutableApplication.saveAndGet(MutableApplication.java:319)
at
com.netflix.asgard.applications.SpinnakerApplicationService$_createRegisteredApplication_closure5.doCall(SpinnakerApplicationService.groovy:157)
at com.netflix.asgard.TaskService.doWork(TaskService.groovy:92)
at com.netflix.asgard.TaskService.runTask(TaskService.groovy:81)

Asgard is super fragile, and I'm not sure I'm comfortable re-enabling
before we get some chex work done to at least sanity check the relevant
bits.


Reply to this email directly or view it on GitHub
#280.

@ajordens
Copy link
Contributor Author

Effectively just the CRUD operations on Applications.

@danveloper
Copy link
Contributor

Ah, shoot. I knew I was missing one place! @ajordens im happy to update this. Just let me know...

@aglover
Copy link
Contributor

aglover commented Dec 14, 2014

@aglover aglover assigned aglover and unassigned ajordens Dec 14, 2014
@aglover aglover added the moved label Dec 14, 2014
@aglover aglover closed this as completed Dec 14, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants