Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Halyard] No hal command for adding custom resources in Kubernetes account #4345

Closed
anth0d opened this issue Apr 26, 2019 · 8 comments · Fixed by spinnaker/halyard#1436
Closed
Labels

Comments

@anth0d
Copy link

anth0d commented Apr 26, 2019

Issue Summary:
There is no halyard command available to add custom resources in Kubernetes account

Cloud Provider(s):
Kubuernetes Provider V1/ V2

Environment:
Spinnaker Version: 1.9.2
Halyard Version: 1.7.0

Feature Area:
Halyard

Description:
Unavailability of hal command for custom resource addition/deletion to kubernetes account, restricts the automation of accounts creation process, which involves CRD or extension k8 objects.

Steps to Reproduce:
Currently, need to edit halyard config file for addition/deletion of any customResource in kubernetes account:
customResources:

  • kubernetesKind: xxxxxxxxxxx
    versioned: false
  • kubernetesKind: xxxxxxxxxxx
    versioned: false
@ezimanyi
Copy link
Contributor

These were probably never added to Halyard as they are less common than some of the other options, but it certainly would be reasonable to add them. If anyone wants to create a PR for this I'm happy to help and point at similar changes in Halyard.

@spinnakerbot
Copy link

This issue hasn't been updated in 45 days, so we are tagging it as 'stale'. If you want to remove this label, comment:

@spinnakerbot remove-label stale

@anth0d
Copy link
Author

anth0d commented Jun 10, 2019

@spinnakerbot remove-label stale

@spinnakerbot
Copy link

This issue hasn't been updated in 45 days, so we are tagging it as 'stale'. If you want to remove this label, comment:

@spinnakerbot remove-label stale

@amitlt
Copy link

amitlt commented Aug 12, 2019

@spinnakerbot remove-label stale

@thecodejunkie
Copy link

@ezimanyi since there's no commands for it (yet), are there any docs that details it? I only found the config through searching for CRD related things and noticed it in another issue. But I've not been able to find any documentation of either customResouces, kubernetesKind or the versioned property?

@ezimanyi
Copy link
Contributor

@thecodejunkie : There's some documentation here though admittedly it's not entirely complete. If you're just looking to deploy CRDs without any specific customization/extensions then clouddriver will poll your cluster and register any CRDs that it finds. What specifically are you trying to do here?

@jwelch92
Copy link
Contributor

Opened a (rough) PR to add this. First time contributing to halyard so I would appreciate any feedback or suggestions! spinnaker/halyard#1436

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants