[Deck | core] Make error reporting consistent in instance type wizard for angular parts.

[pdk27]

Issue Summary:

Inconsistent CX in error / warning reporting when cloning a server group, until browser is refreshed.
(Issue only relevant to simple mode in instance type selector wizard/ single instance type case within Amazon package. Not sure about other cloud providers' CX.)

Cloud Provider(s):

Possibly all

Environment:

Spinnaker 1.29.x on Ubuntu

Feature Area:

Deck

Description:

From my recent experience of adding features to Deck, here is (partial) analysis of the inconsistent CX:
This particular Angular LOC in core -> serverGroup wizard -> instance type sets the current instanceType in command to null when its unavailable due to incompatibility or other reasons.
In the amazon package, command.dirty.instanceType is used to track and report warnings for incompatible instance types removed (specifically when loading configuration for the Clone operation). Similar practice is seen here. This warning reporting is made possible due to this LOC

The first time clone operation is initiated, the warnings are reported as expected indicating that certain incompatible instance types were removed. See demo [here].(spinnaker/deck#9901 (comment)). Subsequent initiations of clone operation fail to report the same warnings until browser is refreshed - the reason for this is likely the Angular LOC linked that makes command.instanceType null. This leads to inconsistent and confusing CX.

Since the Angular LOC is in core, changing it safely requires a Deck expert / extensive testing in multiple environments and scenarios.

Steps to Reproduce:

On Spinnaker 1.29.x

1. Configure AWS as cloud provider
2. Create an application and a server group with single instance type / simple mode for instance type selector + hvm image
3. Clone the server group and change the image so the instance type from cloned server group becomes incompatible
   e.g. change to paravirtual supported image
4. This should produce a warning and instance type error like
   
5. Close the wizard by clicking Cancel in bottom right
6. Repeat step 3
7. The warning doesn't appear anymore and the error now says Instance Type Required instead of the clear messaging displayed the first time.
8. Refresh the browser and repeat step 3 -> the warning will reappear.

Additional Details:

#6734
spinnaker/deck#9901

[spinnakerbot]

This issue hasn't been updated in 45 days, so we are tagging it as 'stale'. If you want to remove this label, comment:

@spinnakerbot remove-label stale

[siddhu-opsmx]

@pdk27 Could you please test the above fix and let me know whether it's working as expected or not.