fix(aws): Fixing bugs related to clone CX when instance types are incompatible with image/region #9901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ompatible with image/region Displaying warnings when incompatible instance types are removed spinnaker/spinnaker#6734
mattgogerly
reviewed
Nov 4, 2022
packages/amazon/src/serverGroup/configure/wizard/instanceType/InstanceTypeSelector.tsx
Outdated
Show resolved
Hide resolved
packages/amazon/src/serverGroup/configure/wizard/instanceType/InstanceTypeSelector.tsx
Outdated
Show resolved
Hide resolved
|
@Mergifyio update |
dbyron-sf
approved these changes
Nov 7, 2022
✅ Branch has been successfully updated |
|
@Mergifyio backport release-1.29.x |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Nov 8, 2022
…ompatible with image/region (#9901) * fix(aws): Fixing bugs related to clone UX when instance types are incompatible with image/region Displaying warnings when incompatible instance types are removed spinnaker/spinnaker#6734 * fix(aws): PR feedback Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> (cherry picked from commit d7290c4)
mergify bot
added a commit
that referenced
this pull request
Nov 8, 2022
…ompatible with image/region (#9901) (#9907) * fix(aws): Fixing bugs related to clone UX when instance types are incompatible with image/region Displaying warnings when incompatible instance types are removed spinnaker/spinnaker#6734 * fix(aws): PR feedback Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> (cherry picked from commit d7290c4) Co-authored-by: Prathibha Datta Kumar <kprathib@amazon.com>
This was referenced Nov 10, 2022
|
Are there any concerns with also backporting this to 1.28? |
|
@Mergifyio backport release-1.28.x |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Apr 5, 2023
…ompatible with image/region (#9901) * fix(aws): Fixing bugs related to clone UX when instance types are incompatible with image/region Displaying warnings when incompatible instance types are removed spinnaker/spinnaker#6734 * fix(aws): PR feedback Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> (cherry picked from commit d7290c4) # Conflicts: # packages/amazon/src/serverGroup/configure/serverGroupConfiguration.service.ts # packages/amazon/src/serverGroup/configure/wizard/instanceType/advancedMode/AmazonInstanceTypeInfoRenderer.tsx
link108
pushed a commit
to armory-io/deck
that referenced
this pull request
Apr 17, 2023
…ompatible with image/region (spinnaker#9901) * fix(aws): Fixing bugs related to clone UX when instance types are incompatible with image/region Displaying warnings when incompatible instance types are removed spinnaker/spinnaker#6734 * fix(aws): PR feedback Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
link108
pushed a commit
that referenced
this pull request
Apr 17, 2023
…ompatible with image/region (#9901) * fix(aws): Fixing bugs related to clone UX when instance types are incompatible with image/region Displaying warnings when incompatible instance types are removed spinnaker/spinnaker#6734 * fix(aws): PR feedback Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
link108
added a commit
that referenced
this pull request
Apr 18, 2023
#9980) Co-authored-by: Cameron Motevasselani <cmotevasselani@gmail.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: Prathibha Datta Kumar <kprathib@amazon.com> fix(aws): Fixing bugs related to clone CX when instance types are incompatible with image/region (#9901)
link108
added a commit
that referenced
this pull request
Apr 20, 2023
…ompatible with image/region (backport #9901) (#9975) Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: Cameron Motevasselani <cmotevasselani@gmail.com> Co-authored-by: Prathibha Datta Kumar <kprathib@amazon.com> fix(aws): Fixing bugs related to clone CX when instance types are incompatible with image/region (#9901)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
spinnaker/spinnaker#6734
Bug
NoValidationErrorUntilClick.mov
Fix
Fix.mov