Fails to recognize ADFS SAML response #993
Comments
|
For convenience, I'll borrow code segment from above link. assertion.attributeStatements*.attributes.flatten().each { Attribute attribute ->
def name = attribute.name
def values = attribute.attributeValues.collect { (it as XSString)?.value }
attributes[name] = values
}I found that list of AttributeValue in |
|
So I think above code should be changed to something like this: assertion.attributeStatements*.attributes.flatten().each { Attribute attribute ->
def name = attribute.name
def values = attribute.attributeValues.collect { (it as XSAny)?.textContent }
attributes[name] = values
}This is because I've printed it.class.getSimpleName() and it all gave me assertion.attributeStatements*.attributes.flatten().each { Attribute attribute ->
def name = attribute.name
def values = attribute.attributeValues.collect {
if (it instanceof XSString) {
return (it as XSString)?.value
} else if (it instanceof XSAny) {
return (it as XSAny)?.textContent
} else {
return null
}
} findAll { it != null }
attributes[name] = values
}and both gave me correct XAML behavior. Which one seems better? May I send a pull request for this? |
|
@chongkong - I suggest making a small PR to capture your proposed change. @ajordens - can you test it out when the PR is ready? |
|
I'm out of the country right now but happy to verify the proposed changes
|
|
@chongkong - also, consider something like: |
|
@ttomsu Thanks! I just applied it |
I'm using Spinnaker in AWS. I used Spinnaker provided AMI version 42, and I just run
sudo apt-get upgradeso I'm quite sure I'm running a latest version of it.I'm trying to use ADFS SAML for authentication, and I'm stuck on a bug (or more likely, my misconfiguration) that I can't process SAML response in gate.
here's the log from
/var/log/spinnaker/gate/gate.logand following the log, it ends up in this line
My SAMLResponse looks somewhat like this:
and its getting error in this part:
The text was updated successfully, but these errors were encountered: