Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change split to preg_split #163

Closed
wants to merge 1 commit into from
Closed

Change split to preg_split #163

wants to merge 1 commit into from

Conversation

fagundes
Copy link
Contributor

Fix #162 issue.

@saidmoya12
Copy link

Is no correct the Regexp Expression.

Additionally preg_slipt use more process.

@fagundes
Copy link
Contributor Author

I couldn't find the error.

About use more process, first split is deprecated since PHP 5.3 and it was removed in PHP 7.0. Second the difference of process between split and preg_split in this case is irrelevant.

spipu added a commit that referenced this pull request May 17, 2017
@spipu
fix issue from #163
145d821
@spipu
Copy link
Owner

spipu commented May 17, 2017

fixed with the explode method

@spipu spipu closed this May 17, 2017
@fagundes fagundes deleted the hotfix-remove-split branch May 17, 2017 15:01
icebird93 pushed a commit to EduBase/html2pdf that referenced this pull request Jun 18, 2018
@spipu @icebird93
fix issue from spipu#163
1dcd2e3
aaryarajojuH added a commit to aaryarajojuH/spipu that referenced this pull request Feb 2, 2022
@aaryarajojuH
fix issue from spipu/html2pdf#163
5610309
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fagundes @saidmoya12 @spipu