Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Messages make the list move #54

Closed
fredericsureau opened this issue Oct 18, 2011 · 4 comments
Closed

Messages make the list move #54

fredericsureau opened this issue Oct 18, 2011 · 4 comments

Comments

@fredericsureau
Copy link
Contributor

When a message is displayed to the user (e.g. when a bill has been added correctly), this make the bills list move and create an unpleasant blinking effect.

I propose to keep an area dedicated to messages which would avoid list movement. Or a kind of status bar.

This is the same problem with the "add a bill" form.

@almet
Copy link
Member

almet commented Oct 18, 2011

I can see different solutions to this:

  • having the message displayed on top of the actual content
  • let the message displayed, so the list don't move anymore
  • putting the message in the top bar.

Another solution is to not say anything when things happened the right way (maybe less distracting?)

@arnaudbos
Copy link
Contributor

Oh... I LIKE the flash messages :D

Putting it in the top bar is my favorite choice.

arnaudbos added a commit that referenced this issue Nov 2, 2011
@arnaudbos
Copy link
Contributor

I did something here too.

I've just converted the flash message to an absolute positioning and dynamically calculate its position in the center of the screen when displayed.

It's a first step, tell me what you think of it :)

@almet
Copy link
Member

almet commented Nov 16, 2011

that's nice, but I think it could be enhanced. For instance, the color is now the same as the button to add a bill, and the shape as well, and as a user, I don't get why. Maybe could we put it directly in the top header ? Maybe just changing the color could be enough, I'll try some stuff to see what's better IMO.

@almet almet closed this as completed in bb146b0 Nov 27, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants