Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update sqlalchemy requirement from <1.4,>=1.3.0 to >=1.3.0,<1.5 #800

Closed
wants to merge 1 commit into from
Closed

Update sqlalchemy requirement from <1.4,>=1.3.0 to >=1.3.0,<1.5 #800

wants to merge 1 commit into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jul 14, 2021 •
edited
Loading

Updates the requirements on sqlalchemy to permit the latest version.

Release notes

Sourced from sqlalchemy's releases.

1.4.20

Released: June 28, 2021

orm

  • [orm] [bug] [regression] Fixed regression in ORM regarding an internal reconstitution step for the _orm.with_polymorphic() construct, when the user-facing object is garbage collected as the query is processed. The reconstitution was not ensuring the sub-entities for the "polymorphic" case were handled, leading to an AttributeError.

    References: #6680

  • [orm] [bug] [regression] Adjusted _orm.Query.union() and similar set operations to be correctly compatible with the new capabilities just added in #6661, with SQLAlchemy 1.4.19, such that the SELECT statements rendered as elements of the UNION or other set operation will include directly mapped columns that are mapped as deferred; this both fixes a regression involving unions with multiple levels of nesting that would produce a column mismatch, and also allows the _orm.undefer() option to be used at the top level of such a _orm.Query without having to apply the option to each of the elements within the UNION.

    References: #6678

  • [orm] [bug] Adjusted the check in the mapper for a callable object that is used as a @validates validator function or a @reconstructor reconstruction function, to check for "callable" more liberally such as to accommodate objects based on fundamental attributes like __func__ and __call___, rather than testing for MethodType / FunctionType, allowing things like cython functions to work properly. Pull request courtesy Miłosz Stypiński.

    References: #6538

engine

  • [engine] [bug] Fixed an issue in the C extension for the _result.Row class which could lead to a memory leak in the unlikely case of a _result.Row object which referred to an ORM object that then was mutated to refer back to the Row itself, creating a cycle. The Python C APIs for tracking GC cycles has been added to the native _result.Row implementation to accommodate for this case.

    References: #5348

  • [engine] [bug] Fixed old issue where a _sql.select() made against the token "*",

... (truncated)

Commits

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Jul 14, 2021
@dependabot dependabot bot mentioned this pull request Jul 14, 2021
Closed
@zorun
Copy link
Collaborator

zorun commented Jul 18, 2021

@dependabot ignore this minor version

@zorun zorun closed this Jul 18, 2021
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Jul 18, 2021

OK, I won't notify you about version 1.4.x again, unless you re-open this PR or update to a 1.4.x release yourself.

@dependabot dependabot bot deleted the dependabot/pip/master/sqlalchemy-gte-1.3.0-and-lt-1.5 branch July 18, 2021 22:04
@Glandos
Copy link
Member

Glandos commented Jan 25, 2022

@dependabot reopen

@dependabot dependabot bot reopened this Jan 25, 2022
@dependabot dependabot bot restored the dependabot/pip/master/sqlalchemy-gte-1.3.0-and-lt-1.5 branch January 25, 2022 21:46
@Glandos Glandos mentioned this pull request Jan 25, 2022
Closed
@Glandos
Copy link
Member

Glandos commented Jan 25, 2022

OK so now, all mariadb tests failed. It seems that SQLAlchemy now supports sequences for MariaDB >= 10.3, and that the generated statement failed because… it tries to extract the table name from SELECT nextval(…) which does not exist. I didn't manage to find why there is either isinsert or isupdate within the current context by just reading logs.
@zorun do you have some ideas?

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Jan 26, 2022

A newer version of sqlalchemy exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged.

@zorun
Copy link
Collaborator

zorun commented Jan 26, 2022

The log is really verbose, from a quick glance I couldn't spot anything other than list index out of range. It seems you have better eyes than me on this one...

@Glandos
Copy link
Member

Glandos commented Jan 31, 2022

I tried to find help in sqlalchemy/sqlalchemy#7649

@dependabot @Glandos
Update sqlalchemy requirement from <1.4,>=1.3.0 to >=1.3.0,<1.5
f57ea91 
Updates the requirements on [sqlalchemy](https://github.com/sqlalchemy/sqlalchemy) to permit the latest version.
- [Release notes](https://github.com/sqlalchemy/sqlalchemy/releases)
- [Changelog](https://github.com/sqlalchemy/sqlalchemy/blob/master/CHANGES)
- [Commits](https://github.com/sqlalchemy/sqlalchemy/commits)

---
updated-dependencies:
- dependency-name: sqlalchemy
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@Glandos Glandos force-pushed the dependabot/pip/master/sqlalchemy-gte-1.3.0-and-lt-1.5 branch from 0934aae to f57ea91 Compare February 2, 2022 21:00
@Glandos
Copy link
Member

Glandos commented Feb 2, 2022

See kvesteri/sqlalchemy-continuum#264

@almet
Copy link
Member

almet commented Dec 10, 2022

Hi @Glandos, I'm doing some housekeeping, and I'm not sure what to do with this issue. Is it clearer for you?

@Glandos
Copy link
Member

Glandos commented Jan 8, 2023

Yes, it is clearer, I'm just waiting for a fix :(

@Glandos
Copy link
Member

Glandos commented Feb 18, 2023

@dependabot rebase

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Feb 18, 2023

Looks like this PR has been edited by someone other than Dependabot. That means Dependabot can't rebase it - sorry!

If you're happy for Dependabot to recreate it from scratch, overwriting any edits, you can request @dependabot recreate.

@Glandos
Copy link
Member

Glandos commented Feb 18, 2023

@dependabot recreate

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Feb 18, 2023

Superseded by #1145.

@dependabot dependabot bot closed this Feb 18, 2023
@dependabot dependabot bot deleted the dependabot/pip/master/sqlalchemy-gte-1.3.0-and-lt-1.5 branch February 18, 2023 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zorun @Glandos @almet