Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[spiral/tokenizer] Write logs only if debug is enabled #1027

Merged
merged 3 commits into from
Dec 13, 2023

Conversation

msmakouz
Copy link
Member

Q A
Bugfix? ✔️
Breaks BC?
New feature?

Copy link

codecov bot commented Dec 13, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8f8adff) 89.23% compared to head (ad4a43f) 89.22%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1027      +/-   ##
============================================
- Coverage     89.23%   89.22%   -0.01%     
- Complexity     6193     6196       +3     
============================================
  Files           816      816              
  Lines         17455    17446       -9     
============================================
- Hits          15576    15567       -9     
  Misses         1879     1879              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@butschster butschster added this to the 3.10 milestone Dec 13, 2023
@butschster butschster merged commit 24c04a4 into master Dec 13, 2023
12 checks passed
@butschster butschster deleted the tokenizer-logs branch December 13, 2023 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants