Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a console command for validating Tokenizer listeners #1040

Merged
merged 7 commits into from
Dec 28, 2023

Conversation

msmakouz
Copy link
Member

@msmakouz msmakouz commented Dec 21, 2023

Q A
Bugfix?
Breaks BC?
New feature? ✔️

A console command has been added for validating Tokenizer listeners. Listeners without the Spiral\Tokenizer\Attribute\TargetAttribute or Spiral\Tokenizer\Attribute\TargetClass attributes cannot be cached, leading to unnecessary file scanning by the Tokenizer, so it may be useful to check the application and identify such listeners.

To use, need to execute the console command:

php app.php tokenizer:validate

Example output:

222

@msmakouz msmakouz added this to the 3.12 milestone Dec 21, 2023
@msmakouz msmakouz self-assigned this Dec 21, 2023
Copy link

codecov bot commented Dec 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f76682f) 89.41% compared to head (892bcc6) 89.53%.
Report is 4 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1040      +/-   ##
============================================
+ Coverage     89.41%   89.53%   +0.12%     
- Complexity     6229     6234       +5     
============================================
  Files           818      819       +1     
  Lines         17533    17549      +16     
============================================
+ Hits          15677    15713      +36     
+ Misses         1856     1836      -20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@msmakouz msmakouz marked this pull request as draft December 27, 2023 14:59
@butschster butschster marked this pull request as ready for review December 28, 2023 08:53
@butschster butschster modified the milestones: 3.12, 3.11 Dec 28, 2023
@butschster butschster merged commit d8a21b5 into master Dec 28, 2023
9 of 14 checks passed
@butschster butschster deleted the feature/tokenizer-validate branch December 28, 2023 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants