Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[spiral/translator] Add a check for the existence of a message #1062

Merged
merged 1 commit into from
Jan 15, 2024

Conversation

msmakouz
Copy link
Member

Q A
Bugfix? ✔️
Breaks BC?
New feature?
Issues #1060

The code did not check whether the message already exists (loaded from the translation files). A check for the existence of the message in the translation catalogue has been added.

@msmakouz msmakouz added this to the 3.12 milestone Jan 15, 2024
@msmakouz msmakouz self-assigned this Jan 15, 2024
Copy link

codecov bot commented Jan 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a3c133e) 89.50% compared to head (301bb72) 89.51%.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #1062   +/-   ##
=========================================
  Coverage     89.50%   89.51%           
- Complexity     6315     6316    +1     
=========================================
  Files           824      824           
  Lines         17796    17792    -4     
=========================================
- Hits          15929    15927    -2     
+ Misses         1867     1865    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@butschster butschster merged commit 3f18fd9 into master Jan 15, 2024
14 checks passed
@msmakouz msmakouz linked an issue Jan 16, 2024 that may be closed by this pull request
@msmakouz msmakouz deleted the fix-indexer branch January 22, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Translations do not end up in cache and used as keys
2 participants