Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[spiral/core] Using the mixed type in the parameters of the Proxy class methods #1092

Merged
merged 1 commit into from
Mar 11, 2024

Conversation

msmakouz
Copy link
Member

@msmakouz msmakouz commented Mar 7, 2024

Q A
Bugfix? ✔️
Breaks BC?
New feature?

In the implementation of the class, the parameter types can be broader than those of the interface. Explicitly specifying the types of the interface in the Proxy class leads to an error in such a situation. For example:

Spiral\Core\ScopeInterface SCOPED PROXY::runScope(): Argument #1 ($bindings) must be of type array, Spiral\Core\Scope given

The types have been changed to mixed.

@msmakouz msmakouz self-assigned this Mar 7, 2024
@msmakouz msmakouz changed the title [spiral/core] Using the mixed type in the parameters of the Proxy class methods. [spiral/core] Using the mixed type in the parameters of the Proxy class methods Mar 7, 2024
@msmakouz msmakouz added this to the 3.12 milestone Mar 7, 2024
Copy link

codecov bot commented Mar 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.64%. Comparing base (d5fe851) to head (e458c40).

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #1092   +/-   ##
=========================================
  Coverage     89.64%   89.64%           
  Complexity     6355     6355           
=========================================
  Files           830      830           
  Lines         17923    17923           
=========================================
  Hits          16067    16067           
  Misses         1856     1856           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@roxblnfk roxblnfk merged commit 819a092 into master Mar 11, 2024
14 checks passed
@roxblnfk roxblnfk deleted the bugfix/mixed-in-proxy branch March 11, 2024 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants