Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating Exceptions, Files code with PHP 8.1 features #626

Merged
merged 6 commits into from
Mar 28, 2022
Merged

Updating Exceptions, Files code with PHP 8.1 features #626

merged 6 commits into from
Mar 28, 2022

Conversation

msmakouz
Copy link
Member

Q A
Bugfix?
Breaks BC? ✔️
New feature?
Issues #512

@codecov
Copy link

codecov bot commented Mar 26, 2022

Codecov Report

Merging #626 (ed228c5) into 3.0 (06a5b93) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##                3.0     #626      +/-   ##
============================================
- Coverage     83.48%   83.47%   -0.01%     
+ Complexity     5873     5872       -1     
============================================
  Files           667      667              
  Lines         14893    14890       -3     
============================================
- Hits          12433    12430       -3     
  Misses         2460     2460              
Impacted Files Coverage Δ
src/Exceptions/src/AbstractHandler.php 92.30% <100.00%> (ø)
src/Exceptions/src/ConsoleHandler.php 93.33% <100.00%> (-0.09%) ⬇️
src/Exceptions/src/Highlighter.php 100.00% <100.00%> (ø)
src/Exceptions/src/HtmlHandler.php 96.15% <100.00%> (-0.08%) ⬇️
src/Exceptions/src/JsonHandler.php 100.00% <100.00%> (ø)
src/Exceptions/src/PlainHandler.php 97.05% <100.00%> (+0.08%) ⬆️
src/Exceptions/src/Style/ConsoleStyle.php 100.00% <100.00%> (ø)
src/Exceptions/src/Style/HtmlStyle.php 100.00% <100.00%> (ø)
src/Exceptions/src/Style/PlainStyle.php 100.00% <100.00%> (ø)
src/Exceptions/src/ValueWrapper.php 100.00% <100.00%> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 06a5b93...ed228c5. Read the comment docs.

@roxblnfk roxblnfk merged commit 131ff49 into spiral:3.0 Mar 28, 2022
@msmakouz msmakouz deleted the maintenance/exceptions-php-81 branch April 4, 2022 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants