Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add exceptions proxying in Fibers during Scoped run #935

Merged
merged 1 commit into from
Apr 29, 2023

Conversation

roxblnfk
Copy link
Member

Q A
Bugfix? ✔️
Breaks BC?
New feature?

Container Scope now will proxy exceptions through Fibers

@codecov
Copy link

codecov bot commented Apr 29, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.02 ⚠️

Comparison is base (ae80144) 83.82% compared to head (d03dcfb) 83.81%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #935      +/-   ##
============================================
- Coverage     83.82%   83.81%   -0.02%     
- Complexity     5865     5868       +3     
============================================
  Files           765      765              
  Lines         16584    16592       +8     
============================================
+ Hits          13902    13906       +4     
- Misses         2682     2686       +4     
Impacted Files Coverage Δ
src/Core/src/ContainerScope.php 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@butschster butschster added this to the 3.8 milestone Apr 29, 2023
@butschster butschster self-assigned this Apr 29, 2023
@butschster butschster merged commit ad0cb4c into master Apr 29, 2023
@butschster butschster deleted the feature/container-scopes branch April 29, 2023 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants