Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add container scope interface #936

Merged
merged 3 commits into from
May 8, 2023
Merged

Conversation

roxblnfk
Copy link
Member

@roxblnfk roxblnfk commented May 4, 2023

Q A
Bugfix?
Breaks BC?
New feature? ✔️

@codecov
Copy link

codecov bot commented May 4, 2023

Codecov Report

Patch coverage: 80.00% and project coverage change: -0.02 ⚠️

Comparison is base (ad0cb4c) 83.81% compared to head (91a8142) 83.79%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #936      +/-   ##
============================================
- Coverage     83.81%   83.79%   -0.02%     
- Complexity     5868     5870       +2     
============================================
  Files           765      765              
  Lines         16592    16597       +5     
============================================
+ Hits          13906    13908       +2     
- Misses         2686     2689       +3     
Impacted Files Coverage Δ
src/Core/src/Internal/Factory/Ctx.php 100.00% <ø> (ø)
src/Core/src/Container.php 93.51% <80.00%> (-2.60%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@butschster butschster added this to the 3.8 milestone May 4, 2023
@butschster butschster self-assigned this May 4, 2023
@butschster butschster merged commit 2ff31f2 into master May 8, 2023
@butschster butschster deleted the feature/container-scopes branch May 8, 2023 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants