Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support psr/http-message v2 #944

Merged
merged 3 commits into from
Jul 12, 2023
Merged

Support psr/http-message v2 #944

merged 3 commits into from
Jul 12, 2023

Conversation

roxblnfk
Copy link
Member

Q A
Bugfix?
Breaks BC?
New feature?
Issues #929

Expand psr/http-message version.

Warning:
Merging this PR might generate a lot of issues related with the distribution module because it
recommends to use the aws/aws-sdk-php package.
The aws/aws-sdk-php isn't compatible with the psr/http-message 2.x yet.
They've pinned psar/http-message ^1 from aws/aws-sdk-php 3.269.1

aws/aws-sdk-php#2681
aws/aws-sdk-php#2684

Unfortunately, we can't fix this for now since this repository supports PHP versions down to 5.5 and this would be a breaking change. We have started a aws/aws-sdk-php#2638 announcing that we will no longer support versions below 7.2.5 after the minor version bump that will happen on August 15th, 2023.

As a solution I propose to add the aws/aws-sdk-php <3.270 into the conflict section of the composer.json

@codecov
Copy link

codecov bot commented May 29, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (fd79037) 83.74% compared to head (9fa6300) 83.74%.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #944   +/-   ##
=========================================
  Coverage     83.74%   83.74%           
  Complexity     5905     5905           
=========================================
  Files           774      774           
  Lines         16679    16679           
=========================================
+ Hits          13967    13968    +1     
+ Misses         2712     2711    -1     

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@butschster butschster self-requested a review May 29, 2023 10:11
@butschster butschster linked an issue May 29, 2023 that may be closed by this pull request
@roxblnfk roxblnfk marked this pull request as ready for review May 29, 2023 12:55
@butschster butschster self-assigned this Jul 12, 2023
@butschster butschster added this to the 3.8 milestone Jul 12, 2023
@butschster butschster merged commit 813f0fd into master Jul 12, 2023
@roxblnfk roxblnfk deleted the hotfix/psr-htttp-message branch July 12, 2023 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Support for psr/http-message 2.0
2 participants