Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use HTTPS URI for Google Fonts #13

Closed
cvan opened this issue Jan 21, 2016 · 2 comments
Closed

Use HTTPS URI for Google Fonts #13

cvan opened this issue Jan 21, 2016 · 2 comments

Comments

@cvan
Copy link
Contributor

cvan commented Jan 21, 2016

A http URI is used to fetch the "Roboto Condensed" web font. Could this be changed to use https?
@spite
Copy link
Owner

spite commented Jan 30, 2016

8e504d8 should take care of that. If the main page is HTTPS, it will load the font with HTTPS. Does that work?

@cvan
Copy link
Contributor Author

cvan commented Jan 30, 2016

8e504d8 should take care of that. If the main page is HTTPS, it will load the font with HTTPS. Does that work?

that's fine if the page is being served from http://, but if someone is using rStats on a document that isn't being served from a server (e.g., file:///projects/experiments/scene.html), the URL won't get resolved correctly. I usually just always use https:// to be safe.

@spite spite closed this as completed in 662a339 Mar 10, 2016
spite added a commit that referenced this issue Mar 10, 2016
@spite
Merge pull request #14 from cvan/https-webfont
45c2d98 
load web font over HTTPS (fixes #13)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cvan @spite