Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Several fixes #3

Closed
wants to merge 2 commits into from
Closed

Several fixes #3

wants to merge 2 commits into from

Conversation

cpuga
Copy link

@cpuga cpuga commented Oct 25, 2011

Patched project controller adapted to the new API template system (index.api.rsb) & Changed form action URL from absolute to relative

This way search form in projects works again when redmine isn't
installed in site root directory (e.g.: www.mydomain.com/redmine)
@kikito
Copy link
Contributor

kikito commented Nov 21, 2011

Hi there!

Sorry it took me so long to answer this.

I'm under the impression that we are using different versions of redmine or chiliproject. We are using this plugin on a Chiliproject 1.x isntallation, so the "api template system" doesn't seem to be enabled on it yet. You are under 2.x, right?

I'll keep this pull request open so that I don't forget to merge it once we have updated to 2.x.

Regards,

Enrique

@cpuga
Copy link
Author

cpuga commented Nov 22, 2011

Yes, we have redmine 1.2.1.
Anyway, the change in the form action will make your plugin valid in all redmine/chilliproject installs, not only in those on the root directory (http:/www.redmine.com/ vs.http:// www.mydomain.com/redmine).

Best regards,
Carlos.

@kikito
Copy link
Contributor

kikito commented Nov 24, 2011

Hi again, you are absolutely right. The fix is on master now. Thanks!

@kikito
Copy link
Contributor

kikito commented Apr 2, 2012

I've merged a different pull request for the api thing. I believe this solves all the issues this pull request was solving, so I'm closing it down. Please feel free to reopen it if you don't agree.

Sorry for the time it took us to answer to this pull request - we didn't update to 2.x until very recently!

@kikito kikito closed this Apr 2, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants