Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new Button/Label styles + ColorObservable is now available only under kaluga resources #9

Merged
merged 2 commits into from
Oct 26, 2021

Conversation

carmelogallo
Copy link
Contributor

No description provided.

ColorObservable is now available only under kaluga resources
@avdyushin
Copy link
Contributor

avdyushin commented Oct 21, 2021

Now includeResources is used for the whole templates you've added. So then it's false then new generated files will be just empty. It has no sense. What if we can put that templates under stencils/resources and include this path inside *.yml on demand:

templates:
  - ./stencils/
  - ./stencils/resources

Then it will include resource relates templates / generate files

@carmelogallo
Copy link
Contributor Author

carmelogallo commented Oct 21, 2021

Now includeResources is used for the whole templates you've added. So then it's false then new generated files will be just empty. It has no sense. What if we can put that templates under stencils/resources and include this path inside *.yml on demand:

templates:
  - ./stencils/
  - ./stencils/resources

Then it will include resource relates templates / generate files

@avdyushin File won't be empty since Sourcery won't add the file :)

@avdyushin
Copy link
Contributor

Now includeResources is used for the whole templates you've added. So then it's false then new generated files will be just empty. It has no sense. What if we can put that templates under stencils/resources and include this path inside *.yml on demand:

templates:
  - ./stencils/
  - ./stencils/resources

Then it will include resource relates templates / generate files

@avdyushin File won't be empty since Sourcery won't add the file :)

But it will be generated right? Eventually it can be configure to be added into Xcode project automatically (no need to drag'n'drop). So I'd prefer not to see empty files at all :)

@carmelogallo
Copy link
Contributor Author

carmelogallo commented Oct 21, 2021

But it will be generated right? Eventually it can be configure to be added into Xcode project automatically (no need to drag'n'drop). So I'd prefer not to see empty files at all :)

No. That's the point. Sourcery won't generate the file at all :)

@avdyushin
Copy link
Contributor

But it will be generated right? Eventually it can be configure to be added into Xcode project automatically (no need to drag'n'drop). So I'd prefer not to see empty files at all :)

No. That's the point. Sourcery won't generate the file at all :)

Ah, nice, fine by me then

@carmelogallo carmelogallo merged commit ae646f3 into master Oct 26, 2021
@carmelogallo carmelogallo deleted the feature/new-kaluga-button-label-style branch October 26, 2021 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants