-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add countdown time for team to connect/ready up #7
Comments
I've been doing some research on this and it doesn't look like there is anyway to hook in to warm up end (to use the built in competitive warmup). I was going to try counting the number of round_ends to see if warmup was ending, but round_end doesn't even fire at the end of the warmup. The only way I can think of is to have the infinite warmup, then have a custom timer that runs and handles the warmup ending before everyone joins and ends the match if they don't. It could print to console every minute or so and the last 10 seconds. What do you think? |
You're right that the builtin warmup is very tricky to deal with. I do still think it should be possible to use, though. Hooking round_start and checking if no longer in the warmup phase (InWarmup() is now false, but the plugin game state has it in warmup still) could potentially work. |
Yeah that's a good idea, I wasn't sure if it would be weird since they I also checked if it was possible to hook into the warmup messages that get On Tue, Apr 26, 2016 at 3:55 PM, Sean Lewis notifications@github.com
|
What you said kinda works, but I can only get rid of some of the messagessent . I can't get rid of the "MATCH STARTING IN X" larger banner messages. I can hook TextMsg to get rid of those 2 warm up match lines (since they're server chat messages). Also there is a hook for the "WARMUP ENDING" message so maybe that can be used to detect warm up ending and the end the match there so it never shows the MATCH STARTING message. Unless there is a usermessage for those banner messages in the center. |
I don't see why you would need to get rid of any of the messages. |
It says "Match will start when warmup has ended." Then it says "Match On Tue, Apr 26, 2016 at 9:02 PM, Sean Lewis notifications@github.com
|
I know this issues is old, but does this mean that get5 is not using the builtin warmup, right? Is there any way to show "WARMUP" in the center of the screen like the builtin warmup? |
It does - except in some weird edge cases (for example, an admin / another plugin can certainly type |
So, is it possible to show message like "Warmup %s left"? |
If they don't connect/ready in time, the match ends (and the proper forwards fire).
Might mean there should be an additional forward:
Get5_OnFailToStart
with booleans for each match team if they failed to ready up/connect.The text was updated successfully, but these errors were encountered: