Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add countdown time for team to connect/ready up #7

Closed
splewis opened this issue Feb 14, 2016 · 9 comments
Closed

Add countdown time for team to connect/ready up #7

splewis opened this issue Feb 14, 2016 · 9 comments

Comments

@splewis
Copy link
Owner

splewis commented Feb 14, 2016

If they don't connect/ready in time, the match ends (and the proper forwards fire).

Might mean there should be an additional forward: Get5_OnFailToStart with booleans for each match team if they failed to ready up/connect.

@bgilb5
Copy link

bgilb5 commented Apr 26, 2016

I've been doing some research on this and it doesn't look like there is anyway to hook in to warm up end (to use the built in competitive warmup). I was going to try counting the number of round_ends to see if warmup was ending, but round_end doesn't even fire at the end of the warmup. The only way I can think of is to have the infinite warmup, then have a custom timer that runs and handles the warmup ending before everyone joins and ends the match if they don't. It could print to console every minute or so and the last 10 seconds. What do you think?

@splewis
Copy link
Owner Author

splewis commented Apr 26, 2016

You're right that the builtin warmup is very tricky to deal with. I do still think it should be possible to use, though.

Hooking round_start and checking if no longer in the warmup phase (InWarmup() is now false, but the plugin game state has it in warmup still) could potentially work.

@bgilb5
Copy link

bgilb5 commented Apr 26, 2016

Yeah that's a good idea, I wasn't sure if it would be weird since they
might spawn. But I'm guessing round_start is fast enough if you just kicked
them in that check.

I also checked if it was possible to hook into the warmup messages that get
posted in the chat. Right now it says something like ">> Warming ending
soon and match will be starting" every couple seconds and ">> Warmup
ending, match is starting" when warmup ends. It'd be nice to remove those
completely. Not sure if its possible. I tried to see if you can hook
PrintClientMessageToAll

On Tue, Apr 26, 2016 at 3:55 PM, Sean Lewis notifications@github.com
wrote:

You're right that the builtin warmup is very tricky to deal with. I do
still think it should be possible to use, though.

Hooking round_start and checking if no longer in the warmup phase
(InWarmup() is now false, but the plugin game state has it in warmup still)
could potentially work.


You are receiving this because you commented.
Reply to this email directly or view it on GitHub
#7 (comment)

@bgilb5
Copy link

bgilb5 commented Apr 27, 2016

What you said kinda works, but I can only get rid of some of the messagessent . I can't get rid of the "MATCH STARTING IN X" larger banner messages. I can hook TextMsg to get rid of those 2 warm up match lines (since they're server chat messages). Also there is a hook for the "WARMUP ENDING" message so maybe that can be used to detect warm up ending and the end the match there so it never shows the MATCH STARTING message. Unless there is a usermessage for those banner messages in the center.

@splewis
Copy link
Owner Author

splewis commented Apr 27, 2016

I don't see why you would need to get rid of any of the messages.

@bgilb5
Copy link

bgilb5 commented Apr 27, 2016

It says "Match will start when warmup has ended." Then it says "Match
starting in..." Seems kind of misleading

On Tue, Apr 26, 2016 at 9:02 PM, Sean Lewis notifications@github.com
wrote:

I don't see why you would need to get rid of any of the messages.


You are receiving this because you commented.
Reply to this email directly or view it on GitHub
#7 (comment)

@saintplay
Copy link

I know this issues is old,

but does this mean that get5 is not using the builtin warmup, right?

Is there any way to show "WARMUP" in the center of the screen like the builtin warmup?

@splewis
Copy link
Owner Author

splewis commented Apr 17, 2019

but does this mean that get5 is not using the builtin warmup, right?

It does - except in some weird edge cases (for example, an admin / another plugin can certainly type mp_warmup_end in console and get5 won't try to start the warmup again).

@saintplay
Copy link

So, is it possible to show message like "Warmup %s left"?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants