[common] generics, not Any for ComparisonExpression. #386
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #336.
Not entirely happy with this, but at least it removes the viral ramifications of
Any
.One or Two Generics?
NB: if using both
T
andV
:this starts to get awkward. The user then must always place the
value
in the right hand side of the operator when checking. This is somewhat arbitrary.If this is needed, we should rethink the way ComparisonExpression is handled (perhaps provide a method that facilitates this).
Covariant/Contravariant?
Certainly could be useful to widen the generics in this way. However, both ways make sense? Ultimately it depends on what the user's base and derived classes look like. There might be some common patterns with standard data structures that could be usefully accommodated though. However, since that is not known at this point, this PR is not making a decision on it yet.