Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider allowing passing existing ROS2 Node object to setup() method of py_trees_ros.trees.BehaviourTree #181

Closed
sea-bass opened this issue Sep 5, 2022 · 1 comment · Fixed by #188

Comments

@sea-bass
Copy link

sea-bass commented Sep 5, 2022

In py_trees_ros.trees.BehaviourTree, the setup() method always creates a new node named "tree".

I have two requests, which if you agree with, I would be happy to put up a PR:

  1. Can we consider optionally passing in an existing ROS2 node object in setup(), instead of having the tree always create its own node? This allows us to instantiate a ROS enabled BT inside an already created Node (or Node-derived) object.
  2. Right now, the node name is defaulted to "tree". Consider adding an optional argument to change the name, provided an existing node isn't passed in as per the previous item.
@sea-bass sea-bass changed the title Consider allowing passing existing ROS2 Node object to setup() method of py_trees_ros.trees.BehaviorTree Consider allowing passing existing ROS2 Node object to setup() method of py_trees_ros.trees.BehaviourTree Sep 7, 2022
@stonier
Copy link
Member

stonier commented Jan 1, 2023

Good suggestions, I'll go check out the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants