Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve accessiblity #261

Closed
Zatalyz opened this issue Apr 18, 2020 · 1 comment
Closed

Improve accessiblity #261

Zatalyz opened this issue Apr 18, 2020 · 1 comment

Comments

@Zatalyz
Copy link

Zatalyz commented Apr 18, 2020

Hello,
A friend found an accessibility problem on the plugin display. "It is necessary to put the text which precedes the list in label". After exploring, I think I corrected this, in the helper.php file.

ligne 233, base :

$out .= '<span>' . $this->getLang('translations');
if($this->getConf('about')) $out .= $this->showAbout();
$out .= ':</span> ';

Change to :

$out .= '<label for="translate">' . $this->getLang('translations');
if($this->getConf('about')) $out .= $this->showAbout();
$out .= ':</label> ';

ligne 261, base :
$out .= '<select name="id" class="' . $class . '">';

change to :
$out .= '<select name="id" id="translate" class="' . $class . '">';

I submit pull request when I found how make it :)

Zatalyz added a commit to Zatalyz/dokuwiki-plugin-translation that referenced this issue Apr 18, 2020
@splitbrain
Copy link
Owner

form elements have been removed with 6605eed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants