-
-
Notifications
You must be signed in to change notification settings - Fork 365
/
alternative_spec.rb
319 lines (265 loc) · 10 KB
/
alternative_spec.rb
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
# frozen_string_literal: true
require "spec_helper"
require "split/alternative"
describe Split::Alternative do
let(:alternative) {
Split::Alternative.new("Basket", "basket_text")
}
let(:alternative2) {
Split::Alternative.new("Cart", "basket_text")
}
let!(:experiment) {
Split::ExperimentCatalog.find_or_create({ "basket_text" => ["purchase", "refund"] }, "Basket", "Cart")
}
let(:goal1) { "purchase" }
let(:goal2) { "refund" }
it "should have goals" do
expect(alternative.goals).to eq(["purchase", "refund"])
end
it "should have and only return the name" do
expect(alternative.name).to eq("Basket")
end
describe "weights" do
it "should set the weights" do
experiment = Split::Experiment.new("basket_text", alternatives: [{ "Basket" => 0.6 }, { "Cart" => 0.4 }])
first = experiment.alternatives[0]
expect(first.name).to eq("Basket")
expect(first.weight).to eq(0.6)
second = experiment.alternatives[1]
expect(second.name).to eq("Cart")
expect(second.weight).to eq(0.4)
end
it "accepts probability on alternatives" do
Split.configuration.experiments = {
my_experiment: {
alternatives: [
{ name: "control_opt", percent: 67 },
{ name: "second_opt", percent: 10 },
{ name: "third_opt", percent: 23 },
]
}
}
experiment = Split::Experiment.new(:my_experiment)
first = experiment.alternatives[0]
expect(first.name).to eq("control_opt")
expect(first.weight).to eq(0.67)
second = experiment.alternatives[1]
expect(second.name).to eq("second_opt")
expect(second.weight).to eq(0.1)
end
it "accepts probability on some alternatives" do
Split.configuration.experiments = {
my_experiment: {
alternatives: [
{ name: "control_opt", percent: 34 },
"second_opt",
{ name: "third_opt", percent: 23 },
"fourth_opt",
],
}
}
experiment = Split::Experiment.new(:my_experiment)
alts = experiment.alternatives
[
["control_opt", 0.34],
["second_opt", 0.215],
["third_opt", 0.23],
["fourth_opt", 0.215]
].each do |h|
name, weight = h
alt = alts.shift
expect(alt.name).to eq(name)
expect(alt.weight).to eq(weight)
end
end
#
it "allows name param without probability" do
Split.configuration.experiments = {
my_experiment: {
alternatives: [
{ name: "control_opt" },
"second_opt",
{ name: "third_opt", percent: 64 },
],
}
}
experiment = Split::Experiment.new(:my_experiment)
alts = experiment.alternatives
[
["control_opt", 0.18],
["second_opt", 0.18],
["third_opt", 0.64],
].each do |h|
name, weight = h
alt = alts.shift
expect(alt.name).to eq(name)
expect(alt.weight).to eq(weight)
end
end
end
it "should have a default participation count of 0" do
expect(alternative.participant_count).to eq(0)
end
it "should have a default completed count of 0 for each goal" do
expect(alternative.completed_count).to eq(0)
expect(alternative.completed_count(goal1)).to eq(0)
expect(alternative.completed_count(goal2)).to eq(0)
end
it "should belong to an experiment" do
expect(alternative.experiment.name).to eq(experiment.name)
end
it "should save to redis" do
alternative.save
expect(Split.redis.exists?("basket_text:Basket")).to be true
end
it "should increment participation count" do
old_participant_count = alternative.participant_count
alternative.increment_participation
expect(alternative.participant_count).to eq(old_participant_count+1)
end
it "should increment completed count for each goal" do
old_default_completed_count = alternative.completed_count
old_completed_count_for_goal1 = alternative.completed_count(goal1)
old_completed_count_for_goal2 = alternative.completed_count(goal2)
alternative.increment_completion
alternative.increment_completion(goal1)
alternative.increment_completion(goal2)
expect(alternative.completed_count).to eq(old_default_completed_count+1)
expect(alternative.completed_count(goal1)).to eq(old_completed_count_for_goal1+1)
expect(alternative.completed_count(goal2)).to eq(old_completed_count_for_goal2+1)
end
it "can be reset" do
alternative.participant_count = 10
alternative.set_completed_count(4, goal1)
alternative.set_completed_count(5, goal2)
alternative.set_completed_count(6)
alternative.reset
expect(alternative.participant_count).to eq(0)
expect(alternative.completed_count(goal1)).to eq(0)
expect(alternative.completed_count(goal2)).to eq(0)
expect(alternative.completed_count).to eq(0)
end
it "should know if it is the control of an experiment" do
expect(alternative.control?).to be_truthy
expect(alternative2.control?).to be_falsey
end
describe "unfinished_count" do
it "should be difference between participant and completed counts" do
alternative.increment_participation
expect(alternative.unfinished_count).to eq(alternative.participant_count)
end
it "should return the correct unfinished_count" do
alternative.participant_count = 10
alternative.set_completed_count(4, goal1)
alternative.set_completed_count(3, goal2)
alternative.set_completed_count(2)
expect(alternative.unfinished_count).to eq(1)
end
end
describe "conversion rate" do
it "should be 0 if there are no conversions" do
expect(alternative.completed_count).to eq(0)
expect(alternative.conversion_rate).to eq(0)
end
it "calculate conversion rate" do
expect(alternative).to receive(:participant_count).exactly(6).times.and_return(10)
expect(alternative).to receive(:completed_count).and_return(4)
expect(alternative.conversion_rate).to eq(0.4)
expect(alternative).to receive(:completed_count).with(goal1).and_return(5)
expect(alternative.conversion_rate(goal1)).to eq(0.5)
expect(alternative).to receive(:completed_count).with(goal2).and_return(6)
expect(alternative.conversion_rate(goal2)).to eq(0.6)
end
end
describe "probability winner" do
before do
experiment.calc_winning_alternatives
end
it "should have a probability of being the winning alternative (p_winner)" do
expect(alternative.p_winner).not_to be_nil
end
it "should have a probability of being the winner for each goal" do
expect(alternative.p_winner(goal1)).not_to be_nil
end
it "should be possible to set the p_winner" do
alternative.set_p_winner(0.5)
expect(alternative.p_winner).to eq(0.5)
end
it "should be possible to set the p_winner for each goal" do
alternative.set_p_winner(0.5, goal1)
expect(alternative.p_winner(goal1)).to eq(0.5)
end
end
describe "z score" do
it "should return an error string when the control has 0 people" do
expect(alternative2.z_score).to eq("Needs 30+ participants.")
expect(alternative2.z_score(goal1)).to eq("Needs 30+ participants.")
expect(alternative2.z_score(goal2)).to eq("Needs 30+ participants.")
end
it "should return an error string when the data is skewed or incomplete as per the np > 5 test" do
control = experiment.control
control.participant_count = 100
control.set_completed_count(50)
alternative2.participant_count = 50
alternative2.set_completed_count(1)
expect(alternative2.z_score).to eq("Needs 5+ conversions.")
end
it "should return a float for a z_score given proper data" do
control = experiment.control
control.participant_count = 120
control.set_completed_count(20)
alternative2.participant_count = 100
alternative2.set_completed_count(25)
expect(alternative2.z_score).to be_kind_of(Float)
expect(alternative2.z_score).to_not eq(0)
end
it "should correctly calculate a z_score given proper data" do
control = experiment.control
control.participant_count = 126
control.set_completed_count(89)
alternative2.participant_count = 142
alternative2.set_completed_count(119)
expect(alternative2.z_score.round(2)).to eq(2.58)
end
it "should be N/A for the control" do
control = experiment.control
expect(control.z_score).to eq("N/A")
expect(control.z_score(goal1)).to eq("N/A")
expect(control.z_score(goal2)).to eq("N/A")
end
it "should not blow up for Conversion Rates > 1" do
control = experiment.control
control.participant_count = 3474
control.set_completed_count(4244)
alternative2.participant_count = 3434
alternative2.set_completed_count(4358)
expect { control.z_score }.not_to raise_error
expect { alternative2.z_score }.not_to raise_error
end
end
describe "extra_info" do
it "reads saved value of recorded_info in redis" do
saved_recorded_info = { "key_1" => 1, "key_2" => "2" }
Split.redis.hset "#{alternative.experiment_name}:#{alternative.name}", "recorded_info", saved_recorded_info.to_json
extra_info = alternative.extra_info
expect(extra_info).to eql(saved_recorded_info)
end
end
describe "record_extra_info" do
it "saves key" do
alternative.record_extra_info("signup", 1)
expect(alternative.extra_info["signup"]).to eql(1)
end
it "adds value to saved key's value second argument is number" do
alternative.record_extra_info("signup", 1)
alternative.record_extra_info("signup", 2)
expect(alternative.extra_info["signup"]).to eql(3)
end
it "sets saved's key value to the second argument if it's a string" do
alternative.record_extra_info("signup", "Value 1")
expect(alternative.extra_info["signup"]).to eql("Value 1")
alternative.record_extra_info("signup", "Value 2")
expect(alternative.extra_info["signup"]).to eql("Value 2")
end
end
end