Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix case when extra_infos[0] is null #707

Closed
wants to merge 1 commit into from

Conversation

trostli
Copy link
Contributor

@trostli trostli commented Apr 27, 2023

Problem

If some records have extra_infos and some do not, then check on line 19 of _experiment.erb will fail on trying to access a column of null.

Solution

And an extra check to see if that info exists before checking that its a of type Numeric

@trostli trostli changed the title Fx case when extra_infos[0] is null Fix case when extra_infos[0] is null Apr 27, 2023
@trostli
Copy link
Contributor Author

trostli commented Jun 13, 2023

What do you think of this PR @andrehjr ?

@andrehjr
Copy link
Member

andrehjr commented Sep 3, 2023

Hello @trostli, sorry for the delay.

I went with a different approach on #717 and I think I narrowed down how a nil extra_infos[0] was being stored... So I've fixed that and also added a few specs ;)

I've added you as co-author on that commit. Thanks for bringing this up!

@andrehjr andrehjr closed this Sep 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants