Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Tersus Option: Admin Notice #19

Closed
splorp opened this issue Aug 22, 2011 · 11 comments
Closed

New Tersus Option: Admin Notice #19

splorp opened this issue Aug 22, 2011 · 11 comments
Labels

Comments

@splorp
Copy link
Owner

splorp commented Aug 22, 2011

Ok, so I was thinking …

Both Chris and Dan have added a blurb at the top of their Tersus-themed sites explaining why they’re so “unstyled”. Why don‘t we add an optional field on the Tersus Options page that can be used to display admin announcements, or in this case, self-promotional text. As in Chris’ example, the blurb is formatted as a <section> … </section> above the ``

… ` element.

`


      

Blah, blah, blah.


      

Yadda, yadda, yadda.

`

If no text or markup exists in the aforementioned field, then the <section> … </section> doesn‘t get rendered on the page.

What do you folks think?

@cdharrison
Copy link
Collaborator

We could approach this a few ways:

  • A text area that the user could use to put whatever they want, with it defaulting to our message...
  • A checkbox that turns our canned admin message on...
  • Or we could do both...

This would also appear on the Tersus Options page.

@splorp
Copy link
Owner Author

splorp commented Aug 24, 2011

I would like to do both, if possible.

As an admin of several WP sites, I like the idea of being able to easily turn on a site-wide notification or alert. In this case, the notification can double as self-promotion for the theme, as we’re developing it.

I would have a default message inserted into the field, with a means to reset the text. (Is that the function of the “Reset” button in the current Theme Options?) The text would be turned on or off via the checkbox.

@cdharrison
Copy link
Collaborator

I'll see about adding In the next day or two.

@splorp
Copy link
Owner Author

splorp commented Aug 24, 2011

w00t!

If knew my way around my WP functions a bit better, I’d give it a whirl myself.

(And what’s with all that fugly table-ness in there? Most WP code is way cleaner than that. Ugh.)

@cdharrison
Copy link
Collaborator

I'll clean that up. Repurposed it from a tutorial, which I should probably cite in the source...

@splorp
Copy link
Owner Author

splorp commented Aug 25, 2011

Ok, that makes sense.

Sometimes it’s hard to tell whether WP requires all that extra markup, just to keep things from going kerflunky.

There’s obviously no rush to clean that up … in fact, I could take a crack at it as well.

@cdharrison
Copy link
Collaborator

That would be great actually!

@splorp
Copy link
Owner Author

splorp commented Aug 30, 2011

Ok, I tidied up the theme option functions as best I could. There’s still a few <input> cases in there that we aren’t currently using, but they’re not hurting anybody.

The strange thing was that even with all <table> formatting in the code, none of it was appearing in the final rendered page. WP must have been reformatting the HTML for the newer versions, leaving the old formatting for legacy installs.

Which leads to another question … how far backwards compatible should Tersus be?

I’ll open another issue for that discussion.

@splorp
Copy link
Owner Author

splorp commented Nov 29, 2011

After a bit of tinkering, I have successfully added the admin notice (now renamed “Announcement”) settings to the theme options page. The changes are checked in, but not mentioned in the read me yet. I’ll add a mention of the new theme options when I finally get around to tagging version 0.1.4.

I also added back in all of the WP table formatting to keep our theme options looking similar to the rest of the WP admin pages.

Closing this issue.

@splorp splorp closed this as completed Nov 29, 2011
@cdharrison
Copy link
Collaborator

Thanks for implementing this. I'll have more time to hop back in to
help with this over the coming weeks.

On Nov 28, 2011, at 9:57 PM, Grant Hutchinson
reply@reply.github.com
wrote:

After a bit of tinkering, I have successfully added the admin notice (now renamed “Announcement”) settings to the theme options page. The changes are checked in, but not mentioned in the read me yet. I’ll add a mention of the new theme options when I finally get around to tagging version 0.1.4.

I also added back in all of the WP table formatting to keep our theme options looking similar to the rest of the WP admin pages.

Closing this issue.


Reply to this email directly or view it on GitHub:
#19 (comment)

@splorp
Copy link
Owner Author

splorp commented Nov 29, 2011

Strangely enough, it turned out to be much easier to implement than I had thought. Either that or my PHP fu is getting back up to cruising speed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants