-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/issues found in testing #31
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
wojtekzyla
commented
Jul 19, 2023
•
edited
Loading
edited
- Add warnings when deleting groups or profiles which are configured in the inventory.
- No frequency configuration for walk profiles.
- Default number of presented items changed to 20.
- Save configuration from mongo to values.yaml on host machine after clicking 'Apply change'
wojtekzyla
force-pushed
the
fix/issues-found-in-testing
branch
from
July 19, 2023 13:20
07d6357
to
60a9b53
Compare
…ed in the inventory. No frequency configuration for walk profiles. Default number of presented items changed to 20. fix: change message while deleting profiles. Change what is displayed in Frequency column for walk profiles fix: update tests fix: remove unnecessary print fix: improve logging in handle_changes.py, update config_collection in job insted of in CheckIfPreviousJobFailed fix: fix error in celery job fix: update request message in apply_changes fix: typo in return message fix: fix problem with editing walk profile fix: refactor files and write config from mongo to yaml files on host machine fix: change message in error thrown by SaveConfigToFileHandler
wojtekzyla
force-pushed
the
fix/issues-found-in-testing
branch
from
July 25, 2023 12:50
a6a9f99
to
4c4d3ae
Compare
wojtekzyla
force-pushed
the
fix/issues-found-in-testing
branch
from
July 26, 2023 07:38
4c4d3ae
to
2420407
Compare
omrozowicz-splunk
suggested changes
Jul 26, 2023
backend/SC4SNMP_UI_backend/apply_changes/config_to_yaml_utils.py
Outdated
Show resolved
Hide resolved
backend/SC4SNMP_UI_backend/apply_changes/config_to_yaml_utils.py
Outdated
Show resolved
Hide resolved
backend/SC4SNMP_UI_backend/apply_changes/config_to_yaml_utils.py
Outdated
Show resolved
Hide resolved
ajasnosz
approved these changes
Jul 27, 2023
omrozowicz-splunk
approved these changes
Jul 27, 2023
fix: change directory for temp files fix: add test for edited values.yaml file fix: typos and description of yaml_escape_list function
wojtekzyla
force-pushed
the
fix/issues-found-in-testing
branch
from
July 27, 2023 08:47
b947c2d
to
fb615f6
Compare
🎉 This PR is included in version 1.0.0-beta.4 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.