Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that the default configuration is properly merged with the user configuration #83

Open
atoulme opened this issue Apr 15, 2021 · 0 comments

Comments

@atoulme
Copy link
Collaborator

atoulme commented Apr 15, 2021

We have received reports that the defaults are sometimes ignored when loading the user configuration. The pull request #82 will help workaround some of those effects.

To fix this issue, I propose that we make the following changes:

  • Output the effective configuration of fabric-logger at start time.
  • Add more tests checking that defaults do get merged properly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant