fix: 馃悰 pull fabric logger defaults into helm template #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atoulme
approved these changes
Apr 15, 2021
|
馃帀 This PR is included in version 4.2.2 馃帀 The release is available on GitHub release Your semantic-release bot 馃摝馃殌 |
ccordi
reviewed
Apr 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have identified that fabric-logger is, in particular situations, unable to merge and load the configuration defaults.
To alleviate this issue, we will merge the defaults as part of the configuration provided to the fabric-logger container when creating the configMap that will hold the fabric-logger configuration. This has the benefit of creating a complete configuration file with defaults merged in.
However, this is not a satisfactory long term fix - filing #83 for follow up.